[patch] fixes 4557

Chris Johns chrisj at rtems.org
Fri Feb 10 02:39:53 UTC 2023


Hi Zack,

This is close but there are a couple of issues in the commit message we need
fixed. They are the subject line the closing the ticket automatically.

Please run `git commit --amend` to edit the commit message.

Please change commit text to the contents between the dashes:

--------
libmisc/shell: User can't cut using ctrl e and x in medit

Closes #4557
--------

Then send the email like you just have here.

Thanks
Chris

On 10/2/2023 1:35 pm, zack leung wrote:
> fixes 4557 user can't cut using ctrl e and x in medit
> ---
>  cpukit/libmisc/shell/main_edit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c
> index 6e954639e2..8317452b7b 100644
> --- a/cpukit/libmisc/shell/main_edit.c
> +++ b/cpukit/libmisc/shell/main_edit.c
> @@ -1713,7 +1713,6 @@ static void copy_selection(struct editor *ed) {
>    ed->env->clipboard = (unsigned char *) realloc(ed->env->clipboard,
> ed->env->clipsize);
>    if (!ed->env->clipboard) return;
>    copy(ed, ed->env->clipboard, selstart, ed->env->clipsize);
> -  select_toggle(ed);
>  }
>  
>  static void cut_selection(struct editor *ed) {
> @@ -2132,7 +2131,7 @@ static void edit(struct editor *ed) {
>  
>          case ctrl('e'): select_toggle(ed); break;
>          case ctrl('a'): select_all(ed); break;
> -        case ctrl('c'): copy_selection(ed); break;
> +        case ctrl('c'): copy_selection(ed);select_toggle(ed); break;
>          case ctrl('f'): find_text(ed, 0); break;
>          case ctrl('l'): goto_line(ed); break;
>          case ctrl('g'): find_text(ed, 1); break;
> -- 
> 2.39.1
> 
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list