Typo in rtems-libbsd/rtems_waf/rtems.py?

[Heinz Junkes]

Sorry, I just saw my install script threw an error:

rtems at rtems-dev:~/MVME6100_6_INST/kernel$ ./waf bsp_defaults --rtems-bsps=powerpc/beatnik > config.ini
No function 'bsp_defaults' defined in /home/rtems/MVME6100_6_INST/kernel/wscript

Heinz


> On 17. Jan 2023, at 21:08, Chris Johns <chrisj at rtems.org> wrote:
> 
> On 18/1/2023 6:16 am, Frank Kühndel wrote:
>> have you installed RTEMS (not only the tools) in `${RTEMS_ROOT}` before
>> configuring libbsd? If I am not mistaken, installing RTEMS creates the
>> `share/rtems6` directory.
> 
> This is correct and it is a simple and fast key to see if a kernel of a specific
> version has been installed.
> 
>> On 1/17/23 18:11, Heinz Junkes wrote:
>>> Hi,
>>> 
>>> It looks like there is a typo in rtems-libbsd/rtems_waf/rtems.py.
>>> 
>>> rtems_share_rtems_version = os.path.join(rtems_path, 'share', 'rtems' +
>>> rtems_version)
>>> if not os.path.exists(os.path.join(rtems_share_rtems_version)):
>>>      ctx.fatal('RTEMS path is not valid, "%s" not found.' %
>>> (rtems_share_rtems_version))
>>> 
>>> I think that "+ rtems_version" does not belong there?
>>> 
>>> git clonehttps://github.com/RTEMS/rtems-libbsd.git
>>> cd rtems-libbsd/
>>> git checkout 6-freebsd-12
>>> git submodule init
>>> git submodule update rtems_waf
>>> 
>>> ./waf configure --prefix=${RTEMS_ROOT} --rtems-bsps=powerpc/beatnik
>>> --buildset=buildset/default.ini
> 
> As Frank points put the kernel needs to be installed before this command is run.
> 
> Chris
> 
>>> 
>>> leads to :
>>> 
>>> # project  configured on Tue Jan 17 17:46:09 2023 by
>>> # waf 2.0.19 (abi 20, python 20710f0 on linux2)
>>> # using ./waf configure --prefix=/home/rtems/MVME6100_6_RUN/rtems/6
>>> --rtems-bsps=powerpc/beatnik --buildset=buildset/default.ini
>>> #
>>> ----------------------------------------
>>> Setting top to
>>> /home/rtems/MVME6100_6_INST/rtems-libbsd
>>> ----------------------------------------
>>> Setting out to
>>> /home/rtems/MVME6100_6_INST/rtems-libbsd/build
>>> from /home/rtems/MVME6100_6_INST/rtems-libbsd: RTEMS path is not valid,
>>> "/home/rtems/MVME6100_6_RUN/rtems/6/share/rtems6" not found.
>>> 
>>> 
>>> Heinz
>>