[rtems commit] xilinx-zynqmp: Include <rtems/libio.h> for rtems_termios_initialize()

Gedare Bloom gedare at rtems.org
Wed Jun 7 15:14:52 UTC 2023


This is a reasonable workaround for now, but it seems to be overkill
and counter to the point of refactoring the termiostypes.h.

Would a better solution be
#define rtems_termios_initialize() (void)

On Tue, Jun 6, 2023 at 4:34 PM Joel Sherrill <joel at rtems.org> wrote:
>
> Module:    rtems
> Branch:    master
> Commit:    b2967081e5daa673141d714a2e53280898dce566
> Changeset: http://git.rtems.org/rtems/commit/?id=b2967081e5daa673141d714a2e53280898dce566
>
> Author:    Joel Sherrill <joel at rtems.org>
> Date:      Tue Jun  6 17:33:08 2023 -0500
>
> xilinx-zynqmp: Include <rtems/libio.h> for rtems_termios_initialize()
>
> ---
>
>  bsps/aarch64/xilinx-zynqmp/console/console.c    | 1 +
>  bsps/arm/xilinx-zynqmp/console/console-config.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/bsps/aarch64/xilinx-zynqmp/console/console.c b/bsps/aarch64/xilinx-zynqmp/console/console.c
> index 992b8a62da..e0ca14069c 100644
> --- a/bsps/aarch64/xilinx-zynqmp/console/console.c
> +++ b/bsps/aarch64/xilinx-zynqmp/console/console.c
> @@ -38,6 +38,7 @@
>  #include <rtems/bspIo.h>
>  #include <rtems/endian.h>
>  #include <rtems/sysinit.h>
> +#include <rtems/libio.h>   /* for rtems_termios_initialize */
>
>  #include <bsp/aarch64-mmu.h>
>  #include <bsp/fdt.h>
> diff --git a/bsps/arm/xilinx-zynqmp/console/console-config.c b/bsps/arm/xilinx-zynqmp/console/console-config.c
> index b164db78a5..1712073c2c 100644
> --- a/bsps/arm/xilinx-zynqmp/console/console-config.c
> +++ b/bsps/arm/xilinx-zynqmp/console/console-config.c
> @@ -33,6 +33,7 @@
>  #include <rtems/console.h>
>  #include <rtems/bspIo.h>
>  #include <rtems/sysinit.h>
> +#include <rtems/libio.h>   /* for rtems_termios_initialize */
>
>  #include <bsp/irq.h>
>  #include <dev/serial/zynq-uart.h>
>
> _______________________________________________
> vc mailing list
> vc at rtems.org
> http://lists.rtems.org/mailman/listinfo/vc


More information about the devel mailing list