BSP .inc files and .cfg files

[Sebastian Huber]

On 16.06.23 06:35, Chris Johns wrote:
> On 16/6/2023 2:33 pm, Sebastian Huber wrote:
>> On 16.06.23 03:46, Chris Johns wrote:
>>> On 16/6/2023 9:04 am, Joel Sherrill wrote:
>>>> On Thu, Jun 15, 2023 at 5:41 PM Chris Johns <chrisj at rtems.org
>>>> <mailto:chrisj at rtems.org>> wrote:
>>>>
>>>>       Hi,
>>>>
>>>>       Reviewing the RPU patch I noticed a .inc file being added and I wondered
>>>> why so
>>>>       I checked the sources and to my surprise found:
>>>>
>>>>       rtems.git $ find bsps -name \*.inc
>>>>       bsps/v850/gdbv850sim/config/v850sim.inc
>>>>       bsps/m68k/genmcf548x/config/genmcf548x.inc
>>>>       bsps/m68k/gen68340/include/m68340.inc
>>>>       bsps/m68k/gen68340/include/m68349.inc
>>>>       bsps/arm/altera-cyclone-v/config/altcycv.inc
>>>>       bsps/arm/raspberrypi/config/raspberrypi.inc
>>>>       bsps/arm/lpc32xx/config/lpc32xx.inc
>>>>       bsps/arm/beagle/config/beagle.inc
>>>>       bsps/arm/tms570/config/tms570ls3137.inc
>>>>       bsps/arm/xilinx-zynqmp/config/xilinx_zynqmp.inc
>>>>       bsps/arm/xilinx-zynq/config/xilinx_zynq.inc
>>>>       bsps/arm/lpc24xx/config/lpc17xx.inc
>>>>       bsps/arm/lpc24xx/config/lpc40xx.inc
>>>>       bsps/arm/lpc24xx/config/lpc24xx.inc
>>>>       bsps/arm/lm3s69xx/config/lm3s69xx.inc
>>>>       bsps/powerpc/gen5200/config/gen5200.inc
>>>>       bsps/powerpc/tqm8xx/config/tqm8xx.inc
>>>>       bsps/powerpc/mpc55xxevb/config/mpc55xx.inc
>>>>       bsps/powerpc/qoriq/config/qoriq.inc
>>>>       bsps/powerpc/gen83xx/config/gen83xx.inc
>>>>
>>>>
>>>> These likely can. Thinking back, we have cfg files for every BSP
>>>> variant within a family. They often set a variable like CPU and CPU_CFLAGS
>>>> and included a shared .inc file. These all appear to be from BSPs which
>>>> had variants. I think they are remnants and missed when the .cfg files
>>>> were
>>>>
>>>> Would like someone to concur.
>>>>
>>>>
>>>>       And for .cfg there is:
>>>>
>>>>       rtems.git $ find bsps -name \*.cfg | wc -l
>>>>            191
>>>>
>>>>
>>>> Are these installed and used by the application Makefile system. If so, no.
>>> I cannot see any references in spec but Sebastian is the best person to answer
>>> this.
>> They are definitely not used or installed. I think we still have then since they
>> document the post-link actions which are not yet supported by the new build system.
> Ah yes, thanks. What if the files are collected and archived?

I think we should just remove them. We can use the RTEMS 5 branch to 
look up the post-link actions if needed.

> The RPU BSP is adding a new one. Is this what we want to see happen?

No, we don't want to see new ones.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/