[PATCH 1/1] rtemsbsd/sdhci: Fix Arasan driver when no card present

[Kinsey Moore]

On Thu, Mar 23, 2023 at 7:19 PM Rick VanderWal <rvanderwal at bellsouth.net>
wrote:

>
> On 3/23/23 10:26, Kinsey Moore wrote:
>
> On Wed, Mar 22, 2023 at 7:02 PM <rvanderwal at bellsouth.net> wrote:
>
>>
>> +       if (!(RD4(sc, SDHCI_PRESENT_STATE) & SDHCI_CARD_STABLE))
>> +       {
>> +               device_printf(dev,
>> +                       "CD failed to stabilize, setting to not
>> present.\n");
>>
>
> What is "CD"? Should this be "SD"?
>
> CD is the "Card Detect" signal line from the SD card socket. In this case
> it may be better to spell out to avoid confusion.
>
Yes, I think it'd be best to spell this out since none of the surrounding
text does so. I think with that tweak it'll be ready to get committed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20230323/b082d17a/attachment-0001.htm>