problems adding targets to libfs

[Ralf Corsepius]

Am Die, 2001-11-27 um 21.37 schrieb Joel Sherrill:
> 
> 
> Matthew J Fletcher wrote:
> > 
> > Hi,.
> > 
> > I've been trying to add a new filesystem into libfs but have gotten pretty
> > stuck in rtems quite impressive build system,.. :)
> > 
> > [ not very helpfull error message ]
> > 
> > Making all in wrapup
> > gmake[4]: Entering directory `/xfs/rtems-build/c/posix/libfs/wrapup'
> > gmake[4]: *** No rule to make target `../src/jffs/o-optimize/libjffs.a',
> > needed by `o-optimize/libfs.a'.  Stop.
> 
> With one exception, the stuff in your patch appears OK at 1st glance.
At second glance, there is an issue (cf. below) :)

> My reading of the diff is that it is backwards. :)
Yep, seems like it.

> > diff -ru2 ./rtems-ss-20011025/c/src/libfs/configure.ac
> > ./rtems-ss-20011025-clean/c/src/libfs/configure.ac
> > --- ./rtems-ss-20011025/c/src/libfs/configure.ac        Mon Nov 26 10:07:17 2001
> > +++ ./rtems-ss-20011025-clean/c/src/libfs/configure.ac  Fri Oct 12 19:44:57
> > 2001
> > @@ -33,5 +33,4 @@
> >  src/Makefile
> >  src/imfs/Makefile
> > -src/jffs/Makefile
> >  wrapup/Makefile
> >  ])
> > diff -ru2 ./rtems-ss-20011025/c/src/libfs/src/Makefile.am
> > ./rtems-ss-20011025-clean/c/src/libfs/src/Makefile.am
> > --- ./rtems-ss-20011025/c/src/libfs/src/Makefile.am     Wed Nov 21 22:09:38 2001
> > +++ ./rtems-ss-20011025-clean/c/src/libfs/src/Makefile.am       Wed Oct 18 19:10:55
> > 2000
> > @@ -5,7 +5,5 @@
> >  AUTOMAKE_OPTIONS = foreign 1.4
> > 
> > -SUBDIRS = imfs jffs
> > -
> > -# mjf - 21/11/2001 - added jffs
> > +SUBDIRS = imfs
> > 
> >  include $(top_srcdir)/../../../automake/subdirs.am
> > Only in ./rtems-ss-20011025/c/src/libfs/src: jffs
> > diff -ru2 ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.am
> > ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.am
> > --- ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.am  Mon Nov 26 09:27:46
> > 2001
> > +++ ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.am    Wed Oct 18
> > 19:10:55 2000
> > @@ -16,10 +16,5 @@
> >  #endif
> > 
> > -# mjf - 21/11/2001 - added jffs support
> > -#if HAS_JFFS
     ^^^^^^^^^^^^
This is an automake-conditional.

I.e. you need to add the appropriate autoconf/automake magic to
libfs/configure.ac to set it. This basically means you have to apply 

AM_CONDITIONAL(HAS_JFFS,<condition>)

somewhere in libfs/configure.ac.

[Of cause, you have to regenerate the auto* generated files below libfs/
afterwards (e.g. to run cd .../libfs; .../bootstrap)

Ralf