problems adding targets to libfs

[Joel Sherrill]

Matthew J Fletcher wrote:
> 
> Hi,.
> 
> I've been trying to add a new filesystem into libfs but have gotten pretty
> stuck in rtems quite impressive build system,.. :)
> 
> [ not very helpfull error message ]
> 
> Making all in wrapup
> gmake[4]: Entering directory `/xfs/rtems-build/c/posix/libfs/wrapup'
> gmake[4]: *** No rule to make target `../src/jffs/o-optimize/libjffs.a',
> needed by `o-optimize/libfs.a'.  Stop.

With one exception, the stuff in your patch appears OK at 1st glance.  
My reading of the diff is that it is backwards. :)

The remaining questions are:

1.  Did you run bootstrap in the libfs directory?
2.  Did the make descend into src/jffs?
3.  Did it create the src/jffs/o-optimize/libjffs.a file?  Is it there?
4.  For whatever reason, did you try a rebuild from scratch just in
case?

I assume there is not a typo in the name libjffs.a. :)

Is this the Linux JFFS?  And did the licensing question get resolved?

--joel

> the error seems to be that the directory (and files) within
> 'rtems-ss-20011025/c/src/libfs/jff' were not copied across
> to 'rtems-build/c/posix/libfs/jffs' i.e no attempt was made to create the
> directory.
> 
> as with other autoconf / automake based systems i have edited
> the following files,.
> 
> /libfs/src/Makefile.am          // added extra subdir
> /libfs/src/wrapup/Makefile.am   // added extra lib to libfs
> /libfs/configure.ac             // added extra makefile
> 
> so the question is what am i missing ?
> 
> for some more details on what i did i have included a [ edited ] patch
> of my build efforts,..
> 
> [ - patch begins - ]
> 
> diff -ru2 ./rtems-ss-20011025/c/src/exec/sapi/include/confdefs.h
> ./rtems-ss-20011025-clean/c/src/exec/sapi/include/confdefs.h
> --- ./rtems-ss-20011025/c/src/exec/sapi/include/confdefs.h      Mon Nov 26
> 10:22:50 2001
> +++ ./rtems-ss-20011025-clean/c/src/exec/sapi/include/confdefs.h        Tue Oct 16
> 20:05:28 2001
> @@ -104,5 +104,4 @@
> 
>  #include <imfs.h>
> -#include <jffs.h> /* mjf - 28/11/2001 - added initial jffs filesystem */
> 
>  #ifdef CONFIGURE_INIT
> @@ -112,6 +111,4 @@
>  #ifdef CONFIGURE_USE_IMFS_AS_BASE_FILESYSTEM
>    &IMFS_ops,
> -#elif CONFIGURE_USE_JFFS_AS_BASE_FILESYSTEM /* mjf - using jffs as base
> filesystem */
> -  &JFFS_ops,
>  #else  /* using miniIMFS as base filesystem */
>    &miniIMFS_ops,
> 
> diff -ru2 ./rtems-ss-20011025/c/src/libfs/configure.ac
> ./rtems-ss-20011025-clean/c/src/libfs/configure.ac
> --- ./rtems-ss-20011025/c/src/libfs/configure.ac        Mon Nov 26 10:07:17 2001
> +++ ./rtems-ss-20011025-clean/c/src/libfs/configure.ac  Fri Oct 12 19:44:57
> 2001
> @@ -33,5 +33,4 @@
>  src/Makefile
>  src/imfs/Makefile
> -src/jffs/Makefile
>  wrapup/Makefile
>  ])
> diff -ru2 ./rtems-ss-20011025/c/src/libfs/src/Makefile.am
> ./rtems-ss-20011025-clean/c/src/libfs/src/Makefile.am
> --- ./rtems-ss-20011025/c/src/libfs/src/Makefile.am     Wed Nov 21 22:09:38 2001
> +++ ./rtems-ss-20011025-clean/c/src/libfs/src/Makefile.am       Wed Oct 18 19:10:55
> 2000
> @@ -5,7 +5,5 @@
>  AUTOMAKE_OPTIONS = foreign 1.4
> 
> -SUBDIRS = imfs jffs
> -
> -# mjf - 21/11/2001 - added jffs
> +SUBDIRS = imfs
> 
>  include $(top_srcdir)/../../../automake/subdirs.am
> Only in ./rtems-ss-20011025/c/src/libfs/src: jffs
> diff -ru2 ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.am
> ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.am
> --- ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.am  Mon Nov 26 09:27:46
> 2001
> +++ ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.am    Wed Oct 18
> 19:10:55 2000
> @@ -16,10 +16,5 @@
>  #endif
> 
> -# mjf - 21/11/2001 - added jffs support
> -#if HAS_JFFS
> -JFFSLIB = ../src/jffs/$(ARCH)/libjffs.a
> -#endif
> -
> -TMP_LIBS = $(IMFSLIB) $(JFFSLIB)
> +TMP_LIBS = $(IMFSLIB)
> 
>  $(PROJECT_RELEASE)/lib/$(LIBNAME)$(LIB_VARIANT).a: $(LIB)
> diff -ru2 ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.in
> ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.in
> --- ./rtems-ss-20011025/c/src/libfs/wrapup/Makefile.in  Wed Nov 21 22:15:33
> 2001
> +++ ./rtems-ss-20011025-clean/c/src/libfs/wrapup/Makefile.in    Thu Oct 25
> 23:03:49 2001
> @@ -245,12 +245,7 @@
>  #if HAS_IMFS
>  IMFSLIB = ../src/imfs/$(ARCH)/libimfs.a
> -#endif
> 
> -# mjf - 21/11/2001 - added jffs support
> -# if HAS_JFFS
> -JFFSLIB = ../src/jffs/$(ARCH)/libjffs.a
>  #endif
> -
> -TMP_LIBS = $(IMFSLIB) $(JFFSLIB)
> +TMP_LIBS = $(IMFSLIB)
> 
>  PROJECT_TOOLS = $(PROJECT_RELEASE)/build-tools
> diff -ru2 ./rtems-ss-20011025/c/src/libmisc/shell/cmds.c
> ./rtems-ss-20011025-clean/c/src/libmisc/shell/cmds.c
> --- ./rtems-ss-20011025/c/src/libmisc/shell/cmds.c      Mon Nov 26 10:28:36 2001
> +++ ./rtems-ss-20011025-clean/c/src/libmisc/shell/cmds.c        Thu Aug  9 23:08:45
> 2001
> @@ -44,5 +44,4 @@
> 
>  #include <imfs.h>
> -#include <jffs.h> /* mjf - 28/11/2001 - jffs filesystem support - mkfs.jffs
> */
>  #include <rtems/shell.h>
> 
> [ - patch ends - ]
> 
> regards
> 
> ---
> Matthew J Fletcher                      amimjf at connectfree.co.uk
> Software Engineering            Matthew.Fletcher at student.shu.ac.uk
> www.amimjf.org                  ICQ amimjf 44193496
> 
> Since when did ignorance become a point of view ??
> ---