Patch/Bugfix for BOOTP in rtems-ss-20020205

[Thomas Doerfler]

Hi Chris,

> Thomas Doerfler wrote:
> > 
> > Attached is a patch to fix it. Any comments?
> > 
> >   ------------------------------------------------------------------------
> > --- rtems-ss-20020205/c/src/libnetworking/nfs/bootp_subr.c      Wed Sep 19 19:30:38 2001
> > +++ /usr/local/projects/sandbox/zem40/rtems_patch/bootp_subr.c  Mon Mar 18 21:34:08 2002
> > @@ -902,12 +902,16 @@
> >      if (rtems_create_root_fs () < 0) {
> >        printf("Error creating the root filesystem.\nFile not created.\n");
> >        update_files = 0;
> >      }
> > 
> > -  memset(dhcp_hostname, 0, sizeof(dhcp_hostname));
> > -
> > +#if 0
> > +  memset(dhcp_hostname, 0, sizeof(dhcp_hostname));
> > +#else
> > +  dhcp_hostname = NULL;
> > +#endif
> > +
> 
> Should this be:
> 
>   if (dhcp_hostname)
>     free (dhcp_hostname);

Hm, good question. At least it would not hurt. But the line I 
complaint is at the start of bootpc_init, long before any 
bootp options are processed. So at least at the first run of 
bootpc_init, "dhcp_hostname" is definitely NULL. 

The question is: can bootpc_init be called multiple times? 
Normally it will only be called once after system boot, but 
are there other situations?

wkr,
	Thomas.

> 
> 
> -- 
>  Chris Johns, cjohns at cybertec.com.au

--------------------------------------------
IMD Ingenieurbuero fuer Microcomputertechnik
Thomas Doerfler           Herbststrasse 8
D-82178 Puchheim          Germany
email:    Thomas.Doerfler at imd-systems.de
PGP public key available at: http://www.imd-
systems.de/pgp_key.htm