[PATCH] pc386 BSP PCI initialization fix [was: Re: PCI lookup issue: 3c905C-TX not found by RTEMS.]

[Till Straumann]

gregory.menke at gsfc.nasa.gov wrote:
> Karel Gardas writes:
>  > 
>  > Hello,
>  > 
>  > thanks to help provided by Gregory Menke, I was finally able to get my
>  > K6-2/3c905C-TX NIC machine working with RTEMS. As a result of my debug
>  > trip thorough pcibios/elnk.c sources, I've created attached patch. It adds
>  > some more verbose debugging when PCI_DEBUG is defined and fixes pci
>  > initialization by directly calling pcib_init from BSP_pciFindDevice in
>  > case PCI is not yet initialized. I've also tested applying it to the trunk
>  > and it has gone well.
> 
> I think calling pcib_init in this way is probably not the best idea
> for a long-term fix.  Thought he fact that it works suggests theres a
> bug in the pc386 bsp startup. 

True. I just realized that I call pcib_init()
from my application (GeSys) which is a work-around...

A call should probably go into

c/src/lib/libbsp/i386/pc386/startup/bspstart.c:bsp_start()

Nicely, the BSP defines an weak alias of bsp_start for an
application to redefine bsp_start(). Hence it's easy to
test a modified version (doing a pcib_init() call). Make
sure to verify it still works on a PC *without* PCI, then
submit a PR.

T.

> Is there an active maintainer for the
> pc386 family?
> 
> Gregm
> 
> 
> 
>