[PATCH] pc386 BSP PCI initialization fix [was: Re: PCI lookup issue: 3c905C-TX not found by RTEMS.]

[Karel Gardas]

On Tue, 25 Jan 2005, Till Straumann wrote:

> > I think calling pcib_init in this way is probably not the best idea
> > for a long-term fix.  Thought he fact that it works suggests theres a
> > bug in the pc386 bsp startup.
>
> True. I just realized that I call pcib_init()
> from my application (GeSys) which is a work-around...

Perhaps, this is the reason why your 3c905C-TX was detected well and not
mine...

> A call should probably go into
>
> c/src/lib/libbsp/i386/pc386/startup/bspstart.c:bsp_start()

I will have a look into this.

> Nicely, the BSP defines an weak alias of bsp_start for an
> application to redefine bsp_start(). Hence it's easy to
> test a modified version (doing a pcib_init() call). Make
> sure to verify it still works on a PC *without* PCI, then
> submit a PR.

Sorry, except Qemu with -isa option, I don't have any ISA only PC here.

Cheers,
Karel
--
Karel Gardas                  kgardas at objectsecurity.com
ObjectSecurity Ltd.           http://www.objectsecurity.com