Bugs in mcf5282.h return in 4.9.3

[Andrei Chichak]

Hi Thomas (and all),

Back in November you fixed some definitions for the Coldfire 5282. The 4.9.4 release was cut in March, but it didn't seem to pick your changes.

Did they make it into the branch, or is my install broken?

cheers,
Andrei


On 2009-November-19, at 11:02 AM, Thomas Doerfler wrote:

> Hi Andrei,
> 
> I applied the fix to CVS-HEAD. I should have also applied it to the 4.9
> branch, sorry for not doing this.
> 
> I will merge the changes into the branch ASAP.
> 
> wkr,
> Thomas.
> 
> 
> Andrei Chichak schrieb:
>> I posted this earlier, Thomas Dörfler mentioned that he had fixed the issue, but it seems to have made it into 4.9.3. So, here we go:
>> 
>> There are 4 macros in libcpu/m68k/mcf5282/include/mcf5282.h that are missing their parameter declarations.
>> 
>> The definitions of:
>> 
>> MCF5282_SCM_PACR_ACCESSCTRL1
>> MCF5282_SCM_PACR_ACCESSCTRL0
>> MCF5282_SCM_GPACR_ACCESSCTRL
>> MCF5282_QSPI_QCR_CS
>> 
>> all need the parameter "(x)" but the parameter is not declared. Invoking these macros yields an error like
>> 
>> ../src/dspcommtask.c:75: error: 'x' undeclared (first use in this function)
>> 
>> 
>> 
>> Thanks,
>> Andrei
>> 
>> 
>> ---------------------
>> Andrei Chichak
>> 
>> Systems Developer
>> CBF Systems Inc.
>> 4-038 NINT Innovation Centre
>> 11421 Saskatchewan Drive
>> Edmonton, Alberta
>> Canada
>> T6G 2M9
>> 
>> Phone: 780-628-2072
>> Skype: andrei.chichak
>> 
>> 
>> _______________________________________________
>> rtems-users mailing list
>> rtems-users at rtems.org
>> http://www.rtems.org/mailman/listinfo/rtems-users
>> 
>> 
>> _______________________________________________
>> rtems-users mailing list
>> rtems-users at rtems.org
>> http://www.rtems.org/mailman/listinfo/rtems-users
> 
> 
> -- 
> --------------------------------------------
> Embedded Brains GmbH
> Thomas Doerfler           Obere Lagerstr. 30
> D-82178 Puchheim          Germany
> email: Thomas.Doerfler at embedded-brains.de
> Phone: +49-89-18908079-2
> Fax:   +49-89-18908079-9
>