Fwd: [Milkymist-devel] [PATCH] imfs: give a default value to st_blksize

Chris Johns chrisj at rtems.org
Fri Jun 3 23:21:18 UTC 2011


On 4/06/11 5:18 AM, Sebastien Bourdeauducq wrote:
> On Fri, 2011-06-03 at 20:28 +0200, Joel Sherrill wrote:
>> The block size of the IMFS is strictly up to the user within some power of 2 restrictions.
>
> There is nothing else setting st_blksize in IMFS_stat:
> http://www.rtems.com/cvsweb/cvsweb.cgi/rtems/cpukit/libfs/src/imfs/imfs_stat.c?rev=1.14;content-type=text%2Fplain
>
> Should it be set to CONFIGURE_IMFS_MEMFILE_BYTES_PER_BLOCK instead of
> the hardcoded 1024?
>

Yes. This change should be fine.

Chris



More information about the users mailing list