Fwd: [Milkymist-devel] [PATCH] imfs: give a default value to st_blksize

[Joel Sherrill]

No. That's the user visible item to set. It should be assigned to a variable in confdefs.h. You want the variable.  This CONFIGURE_xxx value is only visible with the user value in the file where the user instances the configuration. This is the line.

    int imfs_rq_memfile_bytes_per_block = CONFIGURE_IMFS_MEMFILE_BYTES_PER_BLOCK;

So you want that variable.

FWIW  I actually managed to ssh to oar, grep, and copy that from my phone. :)

--joel

Chris Johns <chrisj at rtems.org> wrote:

>On 4/06/11 5:18 AM, Sebastien Bourdeauducq wrote:
>> On Fri, 2011-06-03 at 20:28 +0200, Joel Sherrill wrote:
>>> The block size of the IMFS is strictly up to the user within some power of 2 restrictions.
>>
>> There is nothing else setting st_blksize in IMFS_stat:
>> http://www.rtems.com/cvsweb/cvsweb.cgi/rtems/cpukit/libfs/src/imfs/imfs_stat.c?rev=1.14;content-type=text%2Fplain
>>
>> Should it be set to CONFIGURE_IMFS_MEMFILE_BYTES_PER_BLOCK instead of
>> the hardcoded 1024?
>>
>
>Yes. This change should be fine.
>
>Chris