cleaner & greener (was Re: A patch for RTEMS4.10.0 PowerPC heap space initialization)

Kate Feng feng1 at bnl.gov
Fri May 13 18:13:11 UTC 2011


Peter Dufault wrote:
> On May 13, 2011, at 1:41 , Kate Feng wrote:
>
>   
>> I agree so.  More comments regarding the attached patch before the
>>     
>
> I never like to see "externs" in C code, it bypasses interface checking.  Is there a header you can declare  "uintptr_t bsp_sbrk_init(uintptr_t, uintptr_t*);" in?
>   
How about rtems/bspIo.h ?

Cheers,
Kate
> Whoever does the final commit can do that additional cleanup, though.
>
>
> Peter
> -----------------
> Peter Dufault
> HD Associates, Inc.      Software and System Engineering
>
>   




More information about the users mailing list