cleaner & greener (was Re: A patch for RTEMS4.10.0 PowerPC heap space initialization)

[Joel Sherrill]

On 05/13/2011 01:13 PM, Kate Feng wrote:
> Peter Dufault wrote:
>> On May 13, 2011, at 1:41 , Kate Feng wrote:
>>
>>
>>> I agree so.  More comments regarding the attached patch before the
>>>
>> I never like to see "externs" in C code, it bypasses interface checking.  Is there a header you can declare  "uintptr_t bsp_sbrk_init(uintptr_t, uintptr_t*);" in?
>>
> How about rtems/bspIo.h ?
>
No.  This is not printk/IO related.

I would lean to bootcard.h since that's where most of this
type of stuff is prototyped.

Hmmm... no Doxygen there.  Something else to do. :(

--joel
> Cheers,
> Kate
>> Whoever does the final commit can do that additional cleanup, though.
>>
>>
>> Peter
>> -----------------
>> Peter Dufault
>> HD Associates, Inc.      Software and System Engineering
>>
>>
> _______________________________________________
> rtems-users mailing list
> rtems-users at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-users


-- 
Joel Sherrill, Ph.D.             Director of Research&  Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985