Use of CONFIGURE_ in virtex{4,5} bsps

[Joel Sherrill]

Thanks. The ticket should now be closed with the patch applied
to master and the 4.11 branch.

Since it was a plain diff, I had to turn it into a git patch. Check
out the link from the ticket. The git commit message also
contained the annotation to close the ticket.

Don't worry. With git, we are all still learning. :)

Thanks again.



--joel

On Thu, Nov 3, 2016 at 7:52 AM, Joel Sherrill <joel at rtems.org> wrote:

> On Nov 3, 2016 5:49 AM, "Tim Cussins" <timcussins at eml.cc> wrote:
> >
> > On Thu, Nov 3, 2016, at 10:22 AM, Tim Cussins wrote:
> > > Currently 2 headers,
> > >
> > > virtex4/include/bsp.h
> > > virtex5/include/bsp.h
> > >
> > > refer to CONFIGURE_INTERRUPT_STACK_MEMORY, which confdefs.h isn't too
> > > happy about.
> > >
> > > Can I assume those headers should be setting BSP_INTERRUPT_STACK_SIZE
> > > instead? FWIW it resolves the issue :)
>
> That's the intention of the macros starting with BSP_. They are values
> where a BSP may desire to override the default.
>
> >
> > Also, I should mention that patching the appropriate bsp.h to use
> > CONFIGURE_INTERRUPT_ STACK_SIZE works too, but assumed that the BSP_
> > prefix was preferred in this context...
>
> Since this is a release branch, can you file a ticket and provide a patch?
> Preferably to fix both. I am happy to apply it to the branch and master, if
> applicable.
>
> I probably should so grep for CONFIGURE_ in all the BSPs.
>
> Thanks.
>
> > T
> > _______________________________________________
> > users mailing list
> > users at rtems.org
> > http://lists.rtems.org/mailman/listinfo/users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/users/attachments/20161103/72fe27f8/attachment-0002.html>