change log for rtems (2010-08-24)

[Joel Sherrill]

Eric.. please comment on the code in the gen68360
BSP I fixed a warning in.

On 08/24/2010 12:20 PM, Ralf Corsepius wrote:
>    On 08/24/2010 07:10 PM, rtems-vc at rtems.org wrote:
>    
>>    *joel*:
>> 2010-08-24	Joel Sherrill<joel.sherrilL at OARcorp.com>
>>
>> 	* startup/init68360.c: Fix type punning warning.
>>
>> M  1.133  c/src/lib/libbsp/m68k/gen68360/ChangeLog
>> M   1.29  c/src/lib/libbsp/m68k/gen68360/startup/init68360.c
>>
>> diff -u rtems/c/src/lib/libbsp/m68k/gen68360/ChangeLog:1.132 rtems/c/src/lib/libbsp/m68k/gen68360/ChangeLog:1.133
>> --- rtems/c/src/lib/libbsp/m68k/gen68360/ChangeLog:1.132	Wed Apr 28 14:16:22 2010
>> +++ rtems/c/src/lib/libbsp/m68k/gen68360/ChangeLog	Tue Aug 24 12:08:07 2010
>> @@ -1,3 +1,7 @@
>> +2010-08-24	Joel Sherrill<joel.sherrilL at OARcorp.com>
>> +
>> +	* startup/init68360.c: Fix type punning warning.
>> +
>>    2010-04-28	Joel Sherrill<joel.sherrilL at OARcorp.com>
>>
>>    	* startup/init68360.c, timer/timer.c: Remove warnings.
>>
>> diff -u rtems/c/src/lib/libbsp/m68k/gen68360/startup/init68360.c:1.28 rtems/c/src/lib/libbsp/m68k/gen68360/startup/init68360.c:1.29
>> --- rtems/c/src/lib/libbsp/m68k/gen68360/startup/init68360.c:1.28	Wed Apr 28 14:16:22 2010
>> +++ rtems/c/src/lib/libbsp/m68k/gen68360/startup/init68360.c	Tue Aug 24 12:08:07 2010
>> @@ -47,6 +47,9 @@
>>    	int i;
>>    	m68k_isr_entry *vbr;
>>    	unsigned long ramSize;
>> +	volatile unsigned long *RamBase_p;
>> +
>> +	RamBase_p = (volatile unsigned long *)&RamBase;
>>      
> This should likely be a void*  and not an unsigned long.
>
>    
Normally I would agree but apparently it has to be read
from 8 times.

          for (i = 0; i < 8; ++i)
-            *((volatile unsigned long *)(unsigned long)&RamBase);
+            *RamBase_p;


> _______________________________________________
> rtems-vc mailing list
> rtems-vc at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-vc
>    


-- 
Joel Sherrill, Ph.D.             Director of Research&  Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985