change log for rtems (2010-08-27)

rtems-vc at rtems.org rtems-vc at rtems.org
Fri Aug 27 18:11:24 UTC 2010


 *joel* (on branch rtems-4-10-branch):
2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>

	PR 1692/filesystem
	* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
	libfs/src/imfs/imfs_eval.c: Fix implementation and use of
	rtems_libio_is_valid_perms().

M 1.2612  cpukit/ChangeLog
M 1.2346.2.64  cpukit/ChangeLog
M   1.79  cpukit/libcsupport/include/rtems/libio.h
M 1.65.2.5  cpukit/libcsupport/include/rtems/libio.h
M    1.7  cpukit/libfs/src/devfs/devfs_eval.c
M 1.6.2.1  cpukit/libfs/src/devfs/devfs_eval.c
M   1.31  cpukit/libfs/src/imfs/imfs_eval.c
M 1.26.2.1  cpukit/libfs/src/imfs/imfs_eval.c

diff -u rtems/cpukit/ChangeLog:1.2611 rtems/cpukit/ChangeLog:1.2612
--- rtems/cpukit/ChangeLog:1.2611	Fri Aug 27 01:42:45 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:32:59 2010
@@ -1,3 +1,10 @@
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1692/filesystem
+	* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
+	libfs/src/imfs/imfs_eval.c: Fix implementation and use of
+	rtems_libio_is_valid_perms().
+
 2010-08-26	Sebastian Huber <sebastian.huber at embedded-brains.de>
 
 	* libfs/src/defaults/default_evalpath.c,

diff -u rtems/cpukit/ChangeLog:1.2346.2.63 rtems/cpukit/ChangeLog:1.2346.2.64
--- rtems/cpukit/ChangeLog:1.2346.2.63	Thu Aug 26 01:35:20 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:33:09 2010
@@ -1,3 +1,10 @@
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1692/filesystem
+	* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
+	libfs/src/imfs/imfs_eval.c: Fix implementation and use of
+	rtems_libio_is_valid_perms().
+
 2010-08-26      Chris Johns <chrisj at rtems.org>
 
         * libfs/src/rfs/rtems-rfs-file.c: Check then load the inode is not

diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.78 rtems/cpukit/libcsupport/include/rtems/libio.h:1.79
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.78	Thu Jul 15 03:10:46 2010
+++ rtems/cpukit/libcsupport/include/rtems/libio.h	Fri Aug 27 12:32:59 2010
@@ -1287,7 +1287,7 @@
  * Verifies that the permission flag is valid.
  */
 #define rtems_libio_is_valid_perms( _perm )     \
- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
 
 /*
  *  Prototypes for filesystem

diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.4 rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.5
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.65.2.4	Thu Jul  1 10:18:06 2010
+++ rtems/cpukit/libcsupport/include/rtems/libio.h	Fri Aug 27 12:33:11 2010
@@ -537,7 +537,7 @@
  * Verifies that the permission flag is valid.
  */
 #define rtems_libio_is_valid_perms( _perm )     \
- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
 
 /*
  *  Prototypes for filesystem

diff -u rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.7
--- rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6	Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/devfs/devfs_eval.c	Fri Aug 27 12:32:59 2010
@@ -40,10 +40,8 @@
   rtems_device_name_t  *device_name_table;
 
   /* see if 'flags' is valid */
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-     assert( 0 );
-     rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   /* get the device name table */
   device_name_table = (rtems_device_name_t *)pathloc->node_access;

diff -u rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6 rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6.2.1
--- rtems/cpukit/libfs/src/devfs/devfs_eval.c:1.6	Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/devfs/devfs_eval.c	Fri Aug 27 12:33:11 2010
@@ -40,10 +40,8 @@
   rtems_device_name_t  *device_name_table;
 
   /* see if 'flags' is valid */
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-     assert( 0 );
-     rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   /* get the device name table */
   device_name_table = (rtems_device_name_t *)pathloc->node_access;

diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.30 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.31
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.30	Thu Aug 12 23:49:31 2010
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c	Fri Aug 27 12:32:59 2010
@@ -80,9 +80,8 @@
   IMFS_jnode_t *jnode;
   int           flags_to_test;
 
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-    rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   jnode = node->node_access;
 

diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.26	Mon May 31 08:56:36 2010
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c	Fri Aug 27 12:33:11 2010
@@ -82,10 +82,8 @@
   IMFS_jnode_t *jnode;
   int           flags_to_test;
 
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-    assert( 0 );
-    rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   jnode = node->node_access;
 


 *joel* (on branch rtems-4-9-branch):
2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>

	PR 1692/filesystem
	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
	implementation and use of rtems_libio_is_valid_perms().

M 1.696.2.108  cpukit/ChangeLog
M 1.1080.2.60  cpukit/ChangeLog
M 1.1539.2.66  cpukit/ChangeLog
M 1.49.2.2  cpukit/libcsupport/include/rtems/libio.h
M 1.50.2.2  cpukit/libcsupport/include/rtems/libio.h
M 1.53.2.2  cpukit/libcsupport/include/rtems/libio.h
M 1.19.4.1  cpukit/libfs/src/imfs/imfs_eval.c
M 1.19.2.1  cpukit/libfs/src/imfs/imfs_eval.c
M 1.20.2.1  cpukit/libfs/src/imfs/imfs_eval.c

diff -u rtems/cpukit/ChangeLog:1.696.2.107 rtems/cpukit/ChangeLog:1.696.2.108
--- rtems/cpukit/ChangeLog:1.696.2.107	Mon Jun 21 11:38:55 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:33:40 2010
@@ -1,3 +1,9 @@
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1692/filesystem
+	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+	implementation and use of rtems_libio_is_valid_perms().
+
 2010-06-21	Peter Dufault <dufault at hda.com>
 
 	PR 1570/cpukit

diff -u rtems/cpukit/ChangeLog:1.1080.2.59 rtems/cpukit/ChangeLog:1.1080.2.60
--- rtems/cpukit/ChangeLog:1.1080.2.59	Mon Jun 21 11:38:46 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:33:28 2010
@@ -1,3 +1,9 @@
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1692/filesystem
+	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+	implementation and use of rtems_libio_is_valid_perms().
+
 2010-06-21	Peter Dufault <dufault at hda.com>
 
 	PR 1570/cpukit

diff -u rtems/cpukit/ChangeLog:1.1539.2.65 rtems/cpukit/ChangeLog:1.1539.2.66
--- rtems/cpukit/ChangeLog:1.1539.2.65	Mon Jun 21 11:38:39 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:33:21 2010
@@ -1,3 +1,9 @@
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1692/filesystem
+	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
+	implementation and use of rtems_libio_is_valid_perms().
+
 2010-06-21	Peter Dufault <dufault at hda.com>
 
 	PR 1570/cpukit

diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.49.2.1	Fri Dec  8 01:23:00 2006
+++ rtems/cpukit/libcsupport/include/rtems/libio.h	Fri Aug 27 12:33:42 2010
@@ -529,7 +529,7 @@
  * Verifies that the permission flag is valid.
  */
 #define rtems_libio_is_valid_perms( _perm )     \
- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
 
 
 /*

diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.50.2.1	Mon Mar  9 09:13:44 2009
+++ rtems/cpukit/libcsupport/include/rtems/libio.h	Fri Aug 27 12:33:30 2010
@@ -529,8 +529,7 @@
  * Verifies that the permission flag is valid.
  */
 #define rtems_libio_is_valid_perms( _perm )     \
- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
-
+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
 
 /*
  *  Prototypes for filesystem

diff -u rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.1 rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.2
--- rtems/cpukit/libcsupport/include/rtems/libio.h:1.53.2.1	Mon Mar  9 09:12:57 2009
+++ rtems/cpukit/libcsupport/include/rtems/libio.h	Fri Aug 27 12:33:22 2010
@@ -530,7 +530,7 @@
  * Verifies that the permission flag is valid.
  */
 #define rtems_libio_is_valid_perms( _perm )     \
- (~ ((~RTEMS_LIBIO_PERMS_RWX) & _perm ))
+ (((~RTEMS_LIBIO_PERMS_RWX) & _perm ) == 0)
 
 
 /*

diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19.4.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19	Tue Feb  8 11:12:54 2005
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c	Fri Aug 27 12:33:30 2010
@@ -79,10 +79,8 @@
   IMFS_jnode_t *jnode;
   int           flags_to_test;
 
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-    assert( 0 );
-    rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   jnode = node->node_access;
 

diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.19	Tue Feb  8 11:12:54 2005
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c	Fri Aug 27 12:33:42 2010
@@ -79,10 +79,8 @@
   IMFS_jnode_t *jnode;
   int           flags_to_test;
 
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-    assert( 0 );
-    rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   jnode = node->node_access;
 

diff -u rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20 rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20.2.1
--- rtems/cpukit/libfs/src/imfs/imfs_eval.c:1.20	Thu Sep  4 03:16:49 2008
+++ rtems/cpukit/libfs/src/imfs/imfs_eval.c	Fri Aug 27 12:33:23 2010
@@ -79,10 +79,8 @@
   IMFS_jnode_t *jnode;
   int           flags_to_test;
 
-  if ( !rtems_libio_is_valid_perms( flags ) ) {
-    assert( 0 );
-    rtems_set_errno_and_return_minus_one( EIO );
-  }
+  if ( !rtems_libio_is_valid_perms( flags ) )
+    rtems_set_errno_and_return_minus_one( EPERM );
 
   jnode = node->node_access;
 


 *joel* (on branch rtems-4-10-branch):
2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>

	PR 1693/filesystem
	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
	checking incorrect pointer and thus had dead code.

M 1.2613  cpukit/ChangeLog
M 1.696.2.109  cpukit/ChangeLog
M 1.1080.2.61  cpukit/ChangeLog
M 1.1539.2.67  cpukit/ChangeLog
M 1.2346.2.65  cpukit/ChangeLog
M   1.39  cpukit/libfs/src/imfs/memfile.c
M 1.25.2.2  cpukit/libfs/src/imfs/memfile.c
M 1.26.2.2  cpukit/libfs/src/imfs/memfile.c
M 1.27.2.2  cpukit/libfs/src/imfs/memfile.c
M 1.32.2.1  cpukit/libfs/src/imfs/memfile.c

diff -u rtems/cpukit/ChangeLog:1.2612 rtems/cpukit/ChangeLog:1.2613
--- rtems/cpukit/ChangeLog:1.2612	Fri Aug 27 12:32:59 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:43:26 2010
@@ -1,5 +1,11 @@
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
+	PR 1693/filesystem
+	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+	checking incorrect pointer and thus had dead code.
+
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
 	PR 1692/filesystem
 	* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
 	libfs/src/imfs/imfs_eval.c: Fix implementation and use of

diff -u rtems/cpukit/ChangeLog:1.696.2.108 rtems/cpukit/ChangeLog:1.696.2.109
--- rtems/cpukit/ChangeLog:1.696.2.108	Fri Aug 27 12:33:40 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:42:39 2010
@@ -1,5 +1,11 @@
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
+	PR 1693/filesystem
+	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+	checking incorrect pointer and thus had dead code.
+
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
 	PR 1692/filesystem
 	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
 	implementation and use of rtems_libio_is_valid_perms().

diff -u rtems/cpukit/ChangeLog:1.1080.2.60 rtems/cpukit/ChangeLog:1.1080.2.61
--- rtems/cpukit/ChangeLog:1.1080.2.60	Fri Aug 27 12:33:28 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:42:50 2010
@@ -1,5 +1,11 @@
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
+	PR 1693/filesystem
+	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+	checking incorrect pointer and thus had dead code.
+
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
 	PR 1692/filesystem
 	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
 	implementation and use of rtems_libio_is_valid_perms().

diff -u rtems/cpukit/ChangeLog:1.1539.2.66 rtems/cpukit/ChangeLog:1.1539.2.67
--- rtems/cpukit/ChangeLog:1.1539.2.66	Fri Aug 27 12:33:21 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:42:59 2010
@@ -1,5 +1,11 @@
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
+	PR 1693/filesystem
+	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+	checking incorrect pointer and thus had dead code.
+
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
 	PR 1692/filesystem
 	* libcsupport/include/rtems/libio.h, libfs/src/imfs/imfs_eval.c: Fix
 	implementation and use of rtems_libio_is_valid_perms().

diff -u rtems/cpukit/ChangeLog:1.2346.2.64 rtems/cpukit/ChangeLog:1.2346.2.65
--- rtems/cpukit/ChangeLog:1.2346.2.64	Fri Aug 27 12:33:09 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 12:43:18 2010
@@ -1,5 +1,11 @@
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
+	PR 1693/filesystem
+	* libfs/src/imfs/memfile.c: IMFS_memfile_get_block_pointer() was
+	checking incorrect pointer and thus had dead code.
+
+2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
 	PR 1692/filesystem
 	* libcsupport/include/rtems/libio.h, libfs/src/devfs/devfs_eval.c,
 	libfs/src/imfs/imfs_eval.c: Fix implementation and use of

diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.38 rtems/cpukit/libfs/src/imfs/memfile.c:1.39
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.38	Fri Jul 30 17:36:32 2010
+++ rtems/cpukit/libfs/src/imfs/memfile.c	Fri Aug 27 12:43:26 2010
@@ -931,7 +931,7 @@
       return 0;
 
     p2 = (block_p *)p1[ doubly ];
-    if ( !p )
+    if ( !p2 )
       return 0;
 
     return (block_p *)&p2[ singly ];

diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.25.2.1	Fri Dec  8 01:23:00 2006
+++ rtems/cpukit/libfs/src/imfs/memfile.c	Fri Aug 27 12:42:40 2010
@@ -1046,7 +1046,7 @@
       return 0;
 
     p2 = (block_p *)p1[ doubly ];
-    if ( !p )
+    if ( !p2 )
       return 0;
 
     return (block_p *)&p2[ singly ];

diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.26.2.1	Mon Mar  9 09:13:44 2009
+++ rtems/cpukit/libfs/src/imfs/memfile.c	Fri Aug 27 12:42:52 2010
@@ -1046,7 +1046,7 @@
       return 0;
 
     p2 = (block_p *)p1[ doubly ];
-    if ( !p )
+    if ( !p2 )
       return 0;
 
     return (block_p *)&p2[ singly ];

diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.1 rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.2
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.27.2.1	Mon Mar  9 09:12:58 2009
+++ rtems/cpukit/libfs/src/imfs/memfile.c	Fri Aug 27 12:43:01 2010
@@ -1046,7 +1046,7 @@
       return 0;
 
     p2 = (block_p *)p1[ doubly ];
-    if ( !p )
+    if ( !p2 )
       return 0;
 
     return (block_p *)&p2[ singly ];

diff -u rtems/cpukit/libfs/src/imfs/memfile.c:1.32 rtems/cpukit/libfs/src/imfs/memfile.c:1.32.2.1
--- rtems/cpukit/libfs/src/imfs/memfile.c:1.32	Mon Jan 18 19:55:28 2010
+++ rtems/cpukit/libfs/src/imfs/memfile.c	Fri Aug 27 12:43:18 2010
@@ -1048,7 +1048,7 @@
       return 0;
 
     p2 = (block_p *)p1[ doubly ];
-    if ( !p )
+    if ( !p2 )
       return 0;
 
     return (block_p *)&p2[ singly ];


 *joel*:
2010-08-27	Joel Sherrill <joel.sherrill at oarcorp.com>

	* libmisc/shell/main_date.c: Use snprintf() not sprintf().

M 1.2614  cpukit/ChangeLog
M    1.7  cpukit/libmisc/shell/main_date.c

diff -u rtems/cpukit/ChangeLog:1.2613 rtems/cpukit/ChangeLog:1.2614
--- rtems/cpukit/ChangeLog:1.2613	Fri Aug 27 12:43:26 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 13:04:28 2010
@@ -1,3 +1,7 @@
+2010-08-27	Joel Sherrill <joel.sherrill at oarcorp.com>
+
+	* libmisc/shell/main_date.c: Use snprintf() not sprintf().
+
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>
 
 	PR 1693/filesystem

diff -u rtems/cpukit/libmisc/shell/main_date.c:1.6 rtems/cpukit/libmisc/shell/main_date.c:1.7
--- rtems/cpukit/libmisc/shell/main_date.c:1.6	Sun Nov 29 06:12:39 2009
+++ rtems/cpukit/libmisc/shell/main_date.c	Fri Aug 27 13:04:28 2010
@@ -52,7 +52,7 @@
     struct timespec timesp;
     char *result;
 
-    sprintf( buf, "%s %s", argv[1], argv[2] );
+    snprintf( buf, sizeof(buf), "%s %s", argv[1], argv[2] );
     result = strptime(
       buf,
       "%Y-%m-%d %T",


 *joel*:
2010-08-27	Joel Sherrill <joel.sherrill at oarcorp.com>

	* libcsupport/src/ctermid.c: Add comment explaining that this use of
	strcpy() is a potential buffer overrun but because the API does not
	provide a way to know the length of the user provided buffer, there
	is nothing we can do about it.

M 1.2615  cpukit/ChangeLog
M    1.7  cpukit/libcsupport/src/ctermid.c

diff -u rtems/cpukit/ChangeLog:1.2614 rtems/cpukit/ChangeLog:1.2615
--- rtems/cpukit/ChangeLog:1.2614	Fri Aug 27 13:04:28 2010
+++ rtems/cpukit/ChangeLog	Fri Aug 27 13:06:46 2010
@@ -1,5 +1,12 @@
 2010-08-27	Joel Sherrill <joel.sherrill at oarcorp.com>
 
+	* libcsupport/src/ctermid.c: Add comment explaining that this use of
+	strcpy() is a potential buffer overrun but because the API does not
+	provide a way to know the length of the user provided buffer, there
+	is nothing we can do about it.
+
+2010-08-27	Joel Sherrill <joel.sherrill at oarcorp.com>
+
 	* libmisc/shell/main_date.c: Use snprintf() not sprintf().
 
 2010-08-27	Joel Sherrill <joel.sherrilL at OARcorp.com>

diff -u rtems/cpukit/libcsupport/src/ctermid.c:1.6 rtems/cpukit/libcsupport/src/ctermid.c:1.7
--- rtems/cpukit/libcsupport/src/ctermid.c:1.6	Thu Sep  4 13:54:13 2003
+++ rtems/cpukit/libcsupport/src/ctermid.c	Fri Aug 27 13:06:46 2010
@@ -30,6 +30,11 @@
   if ( !s )
     return ctermid_name;
 
+  /*
+   *  We have no way of knowing the length of the user provided buffer.
+   *  It may not be large enough but there is no way to know that. :(
+   *  So this is a potential buffer owerrun that we can do nothing about.
+   */
   strcpy( s, ctermid_name );
   return s;
 }


 *joel*:
Update date.

M    1.8  cpukit/libcsupport/src/ctermid.c

diff -u rtems/cpukit/libcsupport/src/ctermid.c:1.7 rtems/cpukit/libcsupport/src/ctermid.c:1.8
--- rtems/cpukit/libcsupport/src/ctermid.c:1.7	Fri Aug 27 13:06:46 2010
+++ rtems/cpukit/libcsupport/src/ctermid.c	Fri Aug 27 13:07:03 2010
@@ -1,7 +1,7 @@
 /*
  *  ctermid() - POSIX 1003.1b 4.7.1 - Generate Terminal Pathname
  *
- *  COPYRIGHT (c) 1989-1999.
+ *  COPYRIGHT (c) 1989-2010.
  *  On-Line Applications Research Corporation (OAR).
  *
  *  The license and distribution terms for this file may be



--

Generated by Deluxe Loginfo [http://www.codewiz.org/projects/index.html#loginfo] 2.122 by Bernardo Innocenti <bernie at develer.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/vc/attachments/20100827/2962f271/attachment-0001.html>


More information about the vc mailing list