[rtems commit] pc386/.../bsp.h: Do not include crt.h

Joel Sherrill joel at rtems.org
Tue Sep 16 21:00:27 UTC 2014


Module:    rtems
Branch:    master
Commit:    6cd20744e5afa91c3787b1efa65106da8b2e8d2d
Changeset: http://git.rtems.org/rtems/commit/?id=6cd20744e5afa91c3787b1efa65106da8b2e8d2d

Author:    Joel Sherrill <joel.sherrill at oarcorp.com>
Date:      Thu Sep  4 10:08:25 2014 -0500

pc386/.../bsp.h: Do not include crt.h

crt.h defines such lovely constants as "RED" and "GREEN" which
have a nasty habit of conflicting with non-BSP code. There is
no reason to include this private .h from bsp.h and pollute the
namespace for applications.

---

 c/src/lib/libbsp/i386/pc386/include/bsp.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/c/src/lib/libbsp/i386/pc386/include/bsp.h b/c/src/lib/libbsp/i386/pc386/include/bsp.h
index cb9555a..ef16b4a 100644
--- a/c/src/lib/libbsp/i386/pc386/include/bsp.h
+++ b/c/src/lib/libbsp/i386/pc386/include/bsp.h
@@ -113,12 +113,6 @@ extern int rtems_3c509_driver_attach(struct rtems_bsdnet_ifconfig *config);
 +--------------------------------------------------------------------------*/
 
 /*-------------------------------------------------------------------------+
-| Video (console) related constants.
-+--------------------------------------------------------------------------*/
-
-#include <crt.h>
-
-/*-------------------------------------------------------------------------+
 | Constants relating to the 8254 (or 8253) programmable interval timers.
 +--------------------------------------------------------------------------*/
 #define IO_TIMER1      0x40



More information about the vc mailing list