multiple pci.h files and duplication

[Joel Sherrill]

I have a patch in testing which eliminates nearly
all of the sparc pci.h. It started life as a copy of an
older cpukit pci.h. :(

I noticed some other PCI bus constants defined
in C files which turned out to also be defined
in C files on other BSPs. I normalized the name
and modified all impacted BSPs. It will take some
time to ensure it all builds.

I will commit once this is tested and then we
can re-evaluate the situation.

--joel

On 05/16/2012 12:13 PM, Joel Sherrill wrote:
> Hi
>
> cc'ing Daniel since the biggest culprit is under sparc.
>
> In reviewing the changes for the patch, I chanced upon
> sparc/shared/include/pci.h which appears to duplicate a
> lot of what is in cpukit/include/rtems/pci.h.
>
> Searching for pci.h, I also spotted one in mvme5500 which
> has a few Ids and constants which should be in the cpukit
> pci.h
>
> This is just accidental over the years. The sparc file was
> introduced 5 years ago.
>
> The mvme5500 situation is  only a handful of constants.
> I can easily move them to rtems/pci.h and it is fixed.
> But the sparc version does NOT include rtems/pci.h and thus
> is more work. It duplicates a lot rather than getting it via
> inclusion.
>
> There is also the fact that we don't have any defined process
> for incorporating updates from one of the PCI Id sources.
>
> Any thoughts on how to get back to all the PCI bus constants
> and device ids being defined in the cpukit pci.h?
> -- 
> Joel Sherrill, Ph.D.             Director of Research&   Development
> joel.sherrill at OARcorp.com         On-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
>      Support Available             (256) 722-9985
>


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20120516/6f51e02a/attachment-0001.html>