[PATCH] dosfs: Unsigned compared against 0

[Gedare Bloom]

Well, I'm fixing without testing right now. A lot of these changes due
to Coverity probably are not introducing easily testable cases (other
than to ensure our existing tests pass). I'll try to give a good run
through yet today before I finish up. If nothing seems broken I'll
push them.

-Gedare

On Thu, Sep 5, 2013 at 1:59 PM, Joel Sherrill <joel.sherrill at oarcorp.com> wrote:
> FYI.. push them. :)
>
>
> On 9/5/2013 12:57 PM, Joel Sherrill wrote:
>>
>> On 9/5/2013 12:50 PM, Gedare Bloom wrote:
>>>
>>> On Thu, Sep 5, 2013 at 1:31 PM, Joel Sherrill <joel.sherrill at oarcorp.com>
>>> wrote:
>>>>
>>>> Gedare.. are these from Coverity Scan? They seem
>>>> remarkably picky otherwise. :)
>>>>
>>> Yes. I have some time to kill while I'm running some simulations.
>>>
>>>> If they are, ask when you want another run submitted.
>>>>
>>> Will do. The patches need to be approved and committed first.
>>
>> Just let me know when.
>>
>> It would be nice if others could run them also. But that isn't a high
>> priority. I still have robbery clean up items WAY higher than that.
>>>>
>>>> --joel
>>>>
>>>>
>>>> On 9/5/2013 12:10 PM, Gedare Bloom wrote:
>>>>>
>>>>> Fix the type of "cmpltd" to be ssize_t so that assigning it to -1
>>>>> will terminate processing as intended.
>>>>> ---
>>>>>     cpukit/libfs/src/dosfs/msdos_dir.c |    2 +-
>>>>>     1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/cpukit/libfs/src/dosfs/msdos_dir.c
>>>>> b/cpukit/libfs/src/dosfs/msdos_dir.c
>>>>> index 253203c..d7f6823 100644
>>>>> --- a/cpukit/libfs/src/dosfs/msdos_dir.c
>>>>> +++ b/cpukit/libfs/src/dosfs/msdos_dir.c
>>>>> @@ -78,7 +78,7 @@ msdos_dir_read(rtems_libio_t *iop, void *buffer,
>>>>> size_t
>>>>> count)
>>>>>         const size_t       buf_size = converter->buffer.size;
>>>>>         uint32_t           start = 0;
>>>>>         ssize_t            ret = 0;
>>>>> -    uint32_t           cmpltd = 0;
>>>>> +    ssize_t            cmpltd = 0;
>>>>>         uint32_t           j = 0, i = 0;
>>>>>         uint32_t           bts2rd = 0;
>>>>>         uint32_t           cur_cln = 0;
>>>>
>>>>
>>>> --
>>>> Joel Sherrill, Ph.D.             Director of Research & Development
>>>> joel.sherrill at OARcorp.com        On-Line Applications Research
>>>> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
>>>> Support Available                (256) 722-9985
>>>>
>>
>
>
> --
> Joel Sherrill, Ph.D.             Director of Research & Development
> joel.sherrill at OARcorp.com        On-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
> Support Available                (256) 722-9985
>