rtems_test_end()/TEST_END() issues

[Sebastian Huber]

On 2014-05-16 19:48, Joel Sherrill wrote:
> On 5/16/2014 7:09 AM, Sebastian Huber wrote:
>> >Hello Joel,
>> >
>> >I think this rtems_test_* stuff is a hack.  What we really need in the long run
>> >is a proper test framework.
> I don't disagree but we have to have confidence in what is done now.
>
> You added rtems_test_end* and the TEST_END() macro. They do not
> appear to have been applied to the testsuite consistently.
>
> + block08 defined its own version of TEST_END() and you missed
> correcting that.

No, I didn't miss it.  This test doesn't use <tmacros.h>.

>
> + Some tests directly call rtems_test_end() which seems wrong.

./samples/loopback/init.c:    rtems_test_end();
./samples/capture/init.c:    rtems_test_end();
./samples/paranoia/init.c:  rtems_test_end();
./samples/hello/init.c:  rtems_test_end();
./libtests/mathl/init.c:  rtems_test_end();
./libtests/math/init.c:  rtems_test_end();
./libtests/mathf/init.c:  rtems_test_end();
./libtests/complex/init.c:  rtems_test_end();
./libtests/block08/init.c:  rtems_test_end();

These tests don't use <tmacros.h>.

>
> + Some call rtems_test_endk() directly which may be OK if they
> have a good reason not to possibly use printf(). But a TEST_ENDK
> would have been more consistent and at least a comment
> explaining why it needed to use rtems_test_endk().

All the tests with rtems_test_endk() cannot use printf() at this place or don't 
use printf() at all.  A TEST_ENDK() macro makes no sense.  The TEST_END() is 
defined in buffer_test_io.h to reflect the IO redirection already present.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.