[PATCH] libbsp ARM: create abort.h to eliminate warnings Created libbsp/arm/shared/abort/abort.h Edited abort.c and simple_abort.c to include abort.h Changed Raspberry Pi BSP to use abort.c instead of simple_abort.c

[Joel Sherrill]

On 11/3/2014 5:22 AM, Alan Cudmore wrote:
>
> OK, that makes sense. I'll fix it and resubmit the patch. Any other
> ARM BSPs?
>

The warning only shows up in these:

$ grep abort.c warnings-20141030a.txt
      2
c/src/lib/libbsp/arm/rtl22xx/../shared/abort/simple_abort.c:56:6:
warning: no previous prototype for '_print_full_context'
[-Wmissing-prototypes]
      2
c/src/lib/libbsp/arm/rtl22xx/../shared/abort/simple_abort.c:108:6:
warning: no previous prototype for 'do_data_abort' [-Wmissing-prototypes]
      1
c/src/lib/libbsp/arm/raspberrypi/../shared/abort/simple_abort.c:56:6:
warning: no previous prototype for '_print_full_context'
[-Wmissing-prototypes]
      1
c/src/lib/libbsp/arm/raspberrypi/../shared/abort/simple_abort.c:108:6:
warning: no previous prototype for 'do_data_abort' [-Wmissing-prototypes]

which matches a grep:

$ grep simple_abort.c */M*am
raspberrypi/Makefile.am:libbsp_a_SOURCES += ../shared/abort/simple_abort.c
rtl22xx/Makefile.am:libbsp_a_SOURCES += ../shared/abort/simple_abort.c

When I "grep start.S */M*.am" from libbsp/arm, most BSPs use
shared/start/start.S
but a few have their own start.S. Not sure what the impact of that is.

--joel

> Alan
>
> On Nov 3, 2014 2:03 AM, "Sebastian Huber"
> <sebastian.huber at embedded-brains.de
> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>
>     On 03/11/14 02:59, Alan Cudmore wrote:
>
>         -libbsp_a_SOURCES += ../shared/abort/simple_abort.c
>         +libbsp_a_SOURCES += ../shared/abort/abort.c
>
>
>     Since this BSP uses the shared start.S file, I would prefer to
>     remove simple_abort.c and abort.c from the Makefile.am.  These
>     files should go away in the long run.
>
>     The default abort handler is now in:
>
>     http://git.rtems.org/rtems/tree/cpukit/score/cpu/arm/armv4-exception-default.S
>
>     -- 
>     Sebastian Huber, embedded brains GmbH
>
>     Address : Dornierstr. 4, D-82178 Puchheim, Germany
>     Phone   : +49 89 189 47 41-16 <tel:%2B49%2089%20189%2047%2041-16>
>     Fax     : +49 89 189 47 41-09 <tel:%2B49%2089%20189%2047%2041-09>
>     E-Mail  : sebastian.huber at embedded-brains.de
>     <mailto:sebastian.huber at embedded-brains.de>
>     PGP     : Public key available on request.
>
>     Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20141103/d395123f/attachment-0002.html>