[PATCH v2 1/6] Imported files for driver: bcm283x_dwcotg

[Deval Shah]

On Tue, Aug 23, 2016 at 7:08 PM, Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> I updated the MMC support to use the FreeBSD trunk, 2016-08-23,
> 9fe7c416e6abb28b1398fd3e5687099846800cfd. It would be great if you can
> use this version as well as a baseline for your work.
>
>
Is it okay if I provide a new patch (not resend in the previous ones)
updating the code ?


> On 22/08/16 10:37, Deval Shah wrote:
>
>>
>>
>> On Mon, Aug 22, 2016 at 11:25 AM, Sebastian Huber <
>> sebastian.huber at embedded-brains.de <mailto:sebastian.huber at embedd
>> ed-brains.de>> wrote:
>> [...]
>>
>>     If you think the guidelines could be more clear, need an
>>     explanation or examples, then we should address this first.
>>
>>
>> I could use some examples on the last rule " Do not disable option header
>> includes via guards.  Instead, add an empty option header, e.g.
>> `rtemsbsd/include/rtems/bsd/local/opt_xyz.h`.  In general, provide empty
>> header files and do not guard includes. "
>>
>
> Ok, I updated the libbsd.txt.
>
> I have a small doubt here.
https://git.rtems.org/rtems-libbsd/tree/libbsd.txt#n654

Do I have to provide all the headers which I want to ignore, with an empty
file as mentioned or only the ones which are transformed by the import
script ?

For example includes like these.  "#include <dev/ofw/ofw_bus_subr.h>"

>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>


-- 
Deval Shah
Graduate Student,
B.E. (Hons.) Electrical and Electronics Engineering
BITS Pilani Hyderabad Campus <http://www.bits-pilani.ac.in/hyderabad/>

Github Profile <https://github.com/deval-maker>
ᐧ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160827/12b3fb3b/attachment-0002.html>