[PATCH v2 1/6] Imported files for driver: bcm283x_dwcotg

[Deval Shah]

Okay. Understood. I will update and prepare a patch.
ᐧ

On Mon, Aug 29, 2016 at 12:26 PM, Christian Mauderer <
christian.mauderer at embedded-brains.de> wrote:

> Am 27.08.2016 um 13:16 schrieb Deval Shah:
> >
> >
> > On Tue, Aug 23, 2016 at 7:08 PM, Sebastian Huber
> > <sebastian.huber at embedded-brains.de
> > <mailto:sebastian.huber at embedded-brains.de>> wrote:
> >
> >     I updated the MMC support to use the FreeBSD trunk, 2016-08-23,
> >     9fe7c416e6abb28b1398fd3e5687099846800cfd. It would be great if you
> >     can use this version as well as a baseline for your work.
> >
> >
> > Is it okay if I provide a new patch (not resend in the previous ones)
> > updating the code ?
> >
> >
> >     On 22/08/16 10:37, Deval Shah wrote:
> >
> >
> >
> >         On Mon, Aug 22, 2016 at 11:25 AM, Sebastian Huber
> >         <sebastian.huber at embedded-brains.de
> >         <mailto:sebastian.huber at embedded-brains.de>
> >         <mailto:sebastian.huber at embedded-brains.de
> >         <mailto:sebastian.huber at embedded-brains.de>>> wrote:
> >         [...]
> >
> >             If you think the guidelines could be more clear, need an
> >             explanation or examples, then we should address this first.
> >
> >
> >         I could use some examples on the last rule " Do not disable
> >         option header includes via guards.  Instead, add an empty option
> >         header, e.g. `rtemsbsd/include/rtems/bsd/local/opt_xyz.h`.  In
> >         general, provide empty header files and do not guard includes. "
> >
> >
> >     Ok, I updated the libbsd.txt.
> >
> > I have a small doubt
> > here. https://git.rtems.org/rtems-libbsd/tree/libbsd.txt#n654
> >
> > Do I have to provide all the headers which I want to ignore, with an
> > empty file as mentioned or only the ones which are transformed by the
> > import script ?
> >
> > For example includes like these.  "#include <dev/ofw/ofw_bus_subr.h>"
> >
>
> Hello Deval,
>
> Sebastian is currently on vacation so he might need some time to answer.
> I'll try to give some hints but I'm far from being as familiar with
> libbsd as Sebastian is, so he (or some others) might have another opinion.
>
> Regarding the header: Currently mainly the option headers are empty. If
> you do a
>
>    find -size 0 -name "*.h"
>
> (or some other search for empty files) in the libbsd directory, the
> empty headers are option headers and some machine dependent files.
>
> So if you ask me, it should be OK to disable the mentioned
> ofw_bus_subr.h especially because you disabled ofw in the whole file.
>
> On the other hand an option header that you should add as an empty file
> would be opt_platform.h in your patch 5/6.
>
> Kind regards
>
> Christian
> --
> --------------------------------------------
> embedded brains GmbH
> Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.mauderer at embedded-brains.de
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>



-- 
Deval Shah
Graduate Student,
B.E. (Hons.) Electrical and Electronics Engineering
BITS Pilani Hyderabad Campus <http://www.bits-pilani.ac.in/hyderabad/>

Github Profile <https://github.com/deval-maker>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160831/84914611/attachment-0002.html>