[PATCH 01/14] cpuuse/cpuusagetop.c: Fix unused variable warning

[Joel Sherrill]

I don't know how these extra pieces got in that patch. :(

I will remove the pieces other than cpuusagetop.c.

For threadglobalconstruction.c, I am switching to just RTEMS_UNREACHABLE()
in place of this:

#ifdef __GNUC__
  __builtin_unreachable();
#endif
  _Assert_Not_reached();

I will send a new series of patches once the test builds complete.

On Tue, Mar 22, 2016 at 9:46 AM, Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> The commit message doesn't cover all changes.
>
>
> On 22/03/16 15:40, Joel Sherrill wrote:
>
>> ---
>>   cpukit/libmisc/cpuuse/cpuusagetop.c         | 1 -
>>   cpukit/score/src/threadglobalconstruction.c | 3 +++
>>   testsuites/sptests/Makefile.am              | 2 +-
>>   testsuites/sptests/sp13/task1.c             | 9 +++++----
>>   4 files changed, 9 insertions(+), 6 deletions(-)
>>
>> diff --git a/cpukit/libmisc/cpuuse/cpuusagetop.c
>> b/cpukit/libmisc/cpuuse/cpuusagetop.c
>> index 9b92858..cf896e3 100644
>> --- a/cpukit/libmisc/cpuuse/cpuusagetop.c
>> +++ b/cpukit/libmisc/cpuuse/cpuusagetop.c
>> @@ -465,7 +465,6 @@ rtems_cpuusage_top_thread (rtems_task_argument arg)
>>       for (i = 0; i < data->task_count; i++)
>>       {
>>         Thread_Control*   thread = data->tasks[i];
>> -      Timestamp_Control last;
>>         Timestamp_Control usage;
>>         Timestamp_Control current_usage;
>>   diff --git a/cpukit/score/src/threadglobalconstruction.c
>> b/cpukit/score/src/threadglobalconstruction.c
>> index 1e84124..bc96317 100644
>> --- a/cpukit/score/src/threadglobalconstruction.c
>> +++ b/cpukit/score/src/threadglobalconstruction.c
>> @@ -62,5 +62,8 @@ void _Thread_Global_construction(
>>     _Thread_Restart( executing, executing, entry );
>>     _Thread_Enable_dispatch();
>>   +#ifdef __GNUC__
>> +  __builtin_unreachable();
>> +#endif
>>     _Assert_Not_reached();
>>   }
>>
>
> Maybe use new RTEMS_UNREACHABLE(). Maybe the RTEMS_UNREACHABLE() should
> generate a fatal error in case RTEMS_DEBUG is defined to avoid the
> undefined behaviour.
>
> diff --git a/testsuites/sptests/Makefile.am
>> b/testsuites/sptests/Makefile.am
>> index 43f3d82..53adfc1 100644
>> --- a/testsuites/sptests/Makefile.am
>> +++ b/testsuites/sptests/Makefile.am
>> @@ -65,7 +65,7 @@ _SUBDIRS += sptls03
>>   _SUBDIRS += spcpucounter01
>>   if HAS_CPLUSPLUS
>>   _SUBDIRS += spglobalcon01
>> -_SUBDIRS += sptls02
>> +## _SUBDIRS += sptls02
>>   endif
>>   _SUBDIRS += sptls01
>>   _SUBDIRS += spintrcritical20
>>
>
> Conflict with later patch?
>
> diff --git a/testsuites/sptests/sp13/task1.c
>> b/testsuites/sptests/sp13/task1.c
>> index e104e8d..58859c0 100644
>> --- a/testsuites/sptests/sp13/task1.c
>> +++ b/testsuites/sptests/sp13/task1.c
>> @@ -352,10 +352,11 @@ rtems_test_pause();
>>        for (cp = (big_receive_buffer + size);
>>           cp < (big_receive_buffer + sizeof(big_receive_buffer));
>> -        cp++)
>> -    if (*cp != 'Z') {
>> -      puts("TA1 - exact size overrun match failed");
>> -      rtems_test_exit(1);
>> +        cp++) {
>> +      if (*cp != 'Z') {
>> +        puts("TA1 - exact size overrun match failed");
>> +        rtems_test_exit(1);
>> +      }
>>       }
>>         /* all done with this one; delete it */
>>
>
> Conflict with later patch?
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160322/952391a7/attachment-0002.html>