[rtems commit] tests: Use <tmacros.h> in all tests

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Nov 7 07:24:03 UTC 2017


On 07/11/17 08:15, Chris Johns wrote:
> On 07/11/2017 17:09, Sebastian Huber wrote:
>> Commit:    7b00c2fac57740963d3c4d8bf1cf5eab3a31f22e
>> -  rtems_test_begin();
>> +  TEST_BEGIN();
>> -  rtems_test_end();
>> +  TEST_END();
> I am now confused ....
>
> $ arm-rtems4.12-nm `find . -name \*.exe` | grep rtems_test_begin
> 001118dc T rtems_test_begin
> 0011907c T rtems_test_begin
>
> and these are in libtests/math and libtests/capture01 which I suspect have been
> missed with this change.

Ok, I will fix this.

>
> I think the macros TEST_BEGIN and TEST_END should go and the test strings in the
> libmisc/testsupport/test.h should be moved out of the header file and into
> testbeginend.c. I did point this out in ...
>
> https://lists.rtems.org/pipermail/devel/2017-November/019366.html
>
> Just to be clear what I am going to do:
>
> 1. Strip out as much of buffer_test_io.h as I can and rename it test_io.h.
> 2. Remove all TEST_BEGIN and TEST_END macro usage and move all test into
> testbeginend.c.
> 3. Add the banners for version, build and tools.
>
> Sebastian, how does this look to you?

Yes, this is fine, but can we please unify this stuff first. Then you 
only have to change this in one place or do simple search and replace 
changes.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list