[PATCH] Covoar : remove lib parsing as the support is shifted to coverage script

Chris Johns chrisj at rtems.org
Tue Oct 16 05:54:05 UTC 2018


On 16/10/2018 14:37, Vijay Kumar Banerjee wrote:
> ---
>  tester/covoar/DesiredSymbols.cc | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/tester/covoar/DesiredSymbols.cc b/tester/covoar/DesiredSymbols.cc
> index 60d22c3..94ab562 100644
> --- a/tester/covoar/DesiredSymbols.cc
> +++ b/tester/covoar/DesiredSymbols.cc
> @@ -55,10 +55,10 @@ namespace Coverage {
>      // For each set read the libraries from the configuration file and load.
>      //
>      //  [A]
> -    //  libraries = @BUILD-PREFIX@/c/@BSP@/A/libA.a
> +    //  libraries = @BUILD-PREFIX@/c/@BSP@/A
>      //
>      //  [B]
> -    //  libraries = @BUILD-PREFIX@/c/@BSP@/B/libB.a
> +    //  libraries = @BUILD-PREFIX@/c/@BSP@/B
>      //
>      try {
>        cache.open();
> @@ -79,14 +79,12 @@ namespace Coverage {
>          if (verbose)
>            std::cerr << " Symbol set: " << set << std::endl;
>          const rld::config::section& set_section = config.get_section(set);
> -        rld::strings libs;
> -        rld::config::parse_items (set_section, "libraries", libs, true);
> -        for (std::string lib : libs) {
> -          lib = rld::find_replace(lib, "@BUILD-TARGET@", buildTarget);
> -          lib = rld::find_replace(lib, "@BSP@", buildBSP);
> +        rld::strings objs;
> +        rld::config::parse_items (set_section, "libraries", objs, true);
> +        for (std::string obj : objs) {
>            if (verbose)
> -            std::cerr << " Loading library: " << lib << std::endl;
> -          cache.add(lib);
> +            std::cerr << " Loading Object: " << obj << std::endl;
> +          cache.add(obj);

I must be missing how the path in the INI file is transformed into a container
of '.o' files?

I suspect we may need a C++ version of the path.py's 'listdir' that accepts a
regrex and returns a 'paths' container.

Chris



More information about the devel mailing list