[PATCH v2] bsp/raspberrypi: Fix build warnings.

[Niteesh G. S.]

This patch has been unnoticed for a while.
If the lack of testing is what is stopping from pushing it I am happy
to test it on real hardware.

But I can't come up with a good methodology for testing it.
My initial thoughts were to generate a GPIO interrupt with no ISR.
This would cause the default ISR to be called. But I am not familiar
with RTEMS interrupt mechanism so I don't know if this would work or not.

If this is a wrong way to test it, then please let me know of the
right way.

Thanks,
Niteesh.

On Tue, Mar 31, 2020 at 4:21 AM Gedare Bloom <gedare at rtems.org> wrote:

> This looks right but I'm not able to try it out.
>
> On Sat, Mar 28, 2020 at 12:24 PM G S Niteesh Babu <niteesh.gs at gmail.com>
> wrote:
> >
> > 1) _Memory_Initialize makes pointer from integer
> >         without a cast.
> > 2) printf format error, expects %u but %lu provided.
> > ---
> >  bsps/arm/raspberrypi/irq/irq.c             | 4 +++-
> >  bsps/arm/raspberrypi/start/bspstarthooks.c | 2 ++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/bsps/arm/raspberrypi/irq/irq.c
> b/bsps/arm/raspberrypi/irq/irq.c
> > index 9e1bcfc1bc..835cdf97d9 100644
> > --- a/bsps/arm/raspberrypi/irq/irq.c
> > +++ b/bsps/arm/raspberrypi/irq/irq.c
> > @@ -32,6 +32,8 @@
> >  #include <rtems/bspIo.h>
> >  #include <strings.h>
> >
> > +#include <rtems/inttypes.h>
> > +
> >  #ifdef RTEMS_SMP
> >  #include <rtems/score/smp.h>
> >  #include <rtems/score/smpimpl.h>
> > @@ -157,7 +159,7 @@ void
> bsp_interrupt_vector_disable(rtems_vector_number vector)
> >
> >  void bsp_interrupt_handler_default(rtems_vector_number vector)
> >  {
> > -    printk("spurious interrupt: %lu\n", vector);
> > +    printk("spurious interrupt: %" PRIdrtems_vector_number "\n",
> vector);
> >  }
> >
> >  rtems_status_code bsp_interrupt_facility_initialize(void)
> > diff --git a/bsps/arm/raspberrypi/start/bspstarthooks.c
> b/bsps/arm/raspberrypi/start/bspstarthooks.c
> > index fd6aa53059..eb6546db1c 100644
> > --- a/bsps/arm/raspberrypi/start/bspstarthooks.c
> > +++ b/bsps/arm/raspberrypi/start/bspstarthooks.c
> > @@ -184,7 +184,9 @@ static void bsp_memory_initialize(void)
> >  {
> >    _Memory_Initialize(
> >      &_Memory_Areas[0],
> > +    (void *)
> >
> raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].begin,
> > +    (void *)
> >
> raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].end
> >    );
> >  }
> > --
> > 2.17.1
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200410/3a616694/attachment.html>