[PATCH 1/2] cpukit/aarch64: Use hex consistently for offsets

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Dec 9 13:24:47 UTC 2020


Both patches are fine although I am not sure if changes like

  @@ -189,7 +189,7 @@ curr_el_spx_irq_get_pc:			/* The current PC is now in LR */
   * current SP.
   */
  curr_el_spx_fiq:
-	stp x0,	lr,	[sp, #-16]!	/* Push x0,lr on to the stack */
+	stp x0,	lr,	[sp, #-0x10]!	/* Push x0,lr on to the stack */
  	bl curr_el_spx_fiq_get_pc	/* Get current execution address */
  curr_el_spx_fiq_get_pc:			/* The current PC is now in LR */
  	JUMP_HANDLER

really improve readability. It it is always the same 16, then maybe a 
define could be used.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/



More information about the devel mailing list