[PATCH v3] Changed ARM fenv support similar to X86_64

Sebastian Huber sebastian.huber at embedded-brains.de
Sat Jul 18 16:52:14 UTC 2020


On 18/07/2020 18:46, Eshan Dhawan wrote:

>
>
> On Sat, Jul 18, 2020 at 9:32 PM Gedare Bloom <gedare at rtems.org 
> <mailto:gedare at rtems.org>> wrote:
>
>     On Sat, Jul 18, 2020 at 9:39 AM Eshan Dhawan
>     <eshandhawan51 at gmail.com <mailto:eshandhawan51 at gmail.com>> wrote:
>     >
>     >
>     > > On 18-Jul-2020, at 8:51 PM, Sebastian Huber
>     <sebastian.huber at embedded-brains.de
>     <mailto:sebastian.huber at embedded-brains.de>> wrote:
>     > >
>     > > On 18/07/2020 17:17, Eshan Dhawan wrote:
>     > >
>     > >>>>> On 18-Jul-2020, at 4:52 PM, Sebastian Huber
>     <sebastian.huber at embedded-brains.de
>     <mailto:sebastian.huber at embedded-brains.de>> wrote:
>     > >>>> Hello Eshan,
>     > >>>> you produce a lot of extra work for me. Your patch applies
>     now. But it didn't build:
>     > >>>> make[9]: *** No rule to make target 'fenv-vfp.c', needed by
>     'lib_a-fenv-vfp.o'.  Stop.
>     > >>>> make[9]: *** Waiting for unfinished jobs....
>     > >>>> make[9]: Leaving directory
>     '/build/git-build/b-gcc-10.1.0-arm-rtems5/arm-rtems5/thumb/newlib/libm/machine/arm'
>     > >> Fenv-vpf.c file was deleted as well as the declarations were
>     deleted from makefile.am <http://makefile.am>
>     > >> So it shouldn’t be compiled
>     > >> Did you try Remaking the autoconf files after applying the
>     patch ???
>     > >> This patch have the autoconf files
>     > > I don't want to run autoconf myself to test your patches.
>     Please include the build system changes in your patches.
>     > Apologies, I will add the autoconf files from future patches.
>
>     auto* generated output is included for newlib patches, but not for
>     rtems. We don't keep the generated files in our repo.
>
> We don't have to send the auto generated files  in the patch sent to 
> newlib as well
> They are generated by the maintainers there.
> So ,I forgot to send in rtems version of the patch as well. Apologies.

Even though Jeff Johnston mentioned this, not all maintainers do this 
for you.

https://sourceware.org/pipermail/newlib/2020/017679.html

So please regenerate the build files for Newlib patches.



More information about the devel mailing list