[PATCH] rtems: Delete rtems_object_id_api_maximum_class()

[Sebastian Huber]

On 20/11/2020 19:45, Sebastian Huber wrote:
> On 20/11/2020 18:56, Joel Sherrill wrote:
>
>> It should be implemented. File a ticket if you don't want to do it now.
>>
>> But don't delete it. It should be there for completeness. I would 
>> have thought there was code that iterated over all the APIs and 
>> classes and used it. What is being used instead?
>
> This function was added by
>
> commit 6c06288f6452da96fa630f1482aeaaba5d217531
> Author: Joel Sherrill <joel.sherrill at OARcorp.com>
> Date:   Tue Jan 29 21:52:21 2008 +0000
>
>     2008-01-29      Joel Sherrill <joel.sherrill at oarcorp.com>
>
>             * itron/src/exd_tsk.c, itron/src/task.c, 
> libmisc/capture/capture.c,
>             libmisc/monitor/mon-config.c, libmisc/monitor/mon-driver.c,
>             libmisc/monitor/mon-itask.c, libmisc/monitor/mon-monitor.c,
>             libmisc/monitor/mon-mpci.c, libmisc/monitor/mon-object.c,
>             libmisc/monitor/mon-symbols.c, posix/src/cancelrun.c,
>             posix/src/pthreadexit.c, rtems/Makefile.am, 
> rtems/preinstall.am,
>             rtems/include/rtems.h, rtems/include/rtems/rtems/support.h,
>             rtems/inline/rtems/rtems/tasks.inl, rtems/src/eventmp.c,
>             rtems/src/msgmp.c, rtems/src/partmp.c, rtems/src/regionmp.c,
>             rtems/src/rtemsobjectgetname.c, rtems/src/semmp.c,
>             rtems/src/signalmp.c, rtems/src/taskdelete.c, 
> rtems/src/taskmp.c,
>             rtems/src/timerserver.c, score/Makefile.am,
>             score/include/rtems/score/object.h,
>             score/inline/rtems/score/object.inl, score/src/Unlimited.txt,
>             score/src/objectgetnameasstring.c,
>             score/src/threadqextractwithproxy.c: Add new Object Services
>             collection. This changed the name of a few previously 
> public but
>             undocumented services and added a some new services.
>             * rtems/include/rtems/rtems/object.h, 
> rtems/src/rtemsbuildid.c,
>             rtems/src/rtemsbuildname.c, 
> rtems/src/rtemsobjectapimaximumclass.c,
>             rtems/src/rtemsobjectapiminimumclass.c,
>             rtems/src/rtemsobjectgetapiclassname.c,
>             rtems/src/rtemsobjectgetapiname.c,
>             rtems/src/rtemsobjectgetclassicname.c,
>             rtems/src/rtemsobjectgetclassinfo.c,
>             rtems/src/rtemsobjectidapimaximum.c,
>             rtems/src/rtemsobjectidapiminimum.c, 
> rtems/src/rtemsobjectidgetapi.c,
>             rtems/src/rtemsobjectidgetclass.c, 
> rtems/src/rtemsobjectidgetindex.c,
>             rtems/src/rtemsobjectidgetnode.c, 
> rtems/src/rtemsobjectsetname.c,
>             score/src/objectapimaximumclass.c, score/src/objectgetinfo.c,
>             score/src/objectgetinfoid.c, score/src/objectsetname.c: 
> New files.
>             * rtems/src/rtemsidtoname.c: Removed.
>
> Nobody noticed that this function is missing in the last twelve years. 
> What is the differences to:
>
> /**
>  * @brief Get Highest Valid Class Value
>  *
>  * This method returns the highest valid value Class for the
>  * specified @a api. Each API supports a different number
>  * of object classes.
>  *
>  * @param[in] api is the API to obtain the maximum class of
>  *
>  * @retval This method returns the greatet valid value for
>  *         class number for the specified @a api.
>  */
> int rtems_object_api_maximum_class(
>   int api
> );
>
> To me the removed function looks like some fragment left over from 
> development.

We have also this patch which changes the similar 
rtems_object_id_api_minimum_class() in rtems_object_api_minimum_class():

commit fdc57ca4b6794dc17c7b7d94ae557da21e314d6a
Author: Joel Sherrill <joel.sherrill at OARcorp.com>
Date:   Mon Nov 23 14:53:04 2009 +0000

     2009-11-23      Joel Sherrill <joel.sherrill at oarcorp.com>

             PR 1460/cpukit
             * rtems/include/rtems/rtems/object.h,
             rtems/src/rtemsobjectapimaximumclass.c,
             rtems/src/rtemsobjectgetapiclassname.c,
             rtems/src/rtemsobjectgetapiname.c,
             rtems/src/rtemsobjectgetclassinfo.c,
             rtems/src/rtemsobjectidapimaximum.c,
             rtems/src/rtemsobjectidapiminimum.c, 
rtems/src/rtemsobjectidgetapi.c,
             rtems/src/rtemsobjectidgetclass.c, 
rtems/src/rtemsobjectidgetindex.c,
             rtems/src/rtemsobjectidgetnode.c: Change return type on methods
             accessing portions of RTEMS Ids to int. This allows -1 to 
be return
             on error.

diff --git a/cpukit/rtems/include/rtems/rtems/object.h 
b/cpukit/rtems/include/rtems/rtems/object.h
index d419a3b095..5a6e97189a 100644
--- a/cpukit/rtems/include/rtems/rtems/object.h
+++ b/cpukit/rtems/include/rtems/rtems/object.h
@@ -249,15 +249,32 @@ rtems_status_code rtems_object_set_name(
   *  specified @a api.  Each API supports a different number
   *  of object classes.
   *
- *  @param[in] api is the API to obtain the maximum class of
+ *  @param[in] api is the API to obtain the minimum class of
   *
   *  @return This method returns the least valid value for
   *          class number for the specified @a api.
   */
-uint32_t rtems_object_id_api_minimum_class(
-  uint32_t api
+int rtems_object_api_minimum_class(
+  int api
+);

We have a rtems_object_api_maximum_class(). Maybe you forgot to remove 
the rtems_object_id_api_maximum_class() in this patch?

-- 
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/