[PATCH 2/3] Changed variable type to fix AARCH64 test issues

[Joel Sherrill]

On Thu, Mar 18, 2021 at 3:53 PM Gedare Bloom <gedare at rtems.org> wrote:

> I've lost some context, but wasn't this already addressed?
> https://lists.rtems.org/pipermail/devel/2021-March/065021.html


Ryan .. is this a case where the internal tree fixed it one way and
Sebastian fixed it another? Perhaps Sebastian fixed it while this
patch was queued up to go out.

Does aarch64 give a warning or fail without this patch? If not,
then this patch probably isn't needed.

Although I think size_t is probably the right type for this. Please check
that the test has an issue on the master without this patch.


>
>
> On Thu, Mar 18, 2021 at 2:27 PM Ryan Long <ryan.long at oarcorp.com> wrote:
> >
> > Changed maximum_pending_messages to type size_t to fix the
> > ts-validation0 test.
> > ---
> >  cpukit/include/rtems/rtems/message.h                | 2 +-
> >  cpukit/include/rtems/score/coremsgimpl.h            | 2 +-
> >  cpukit/score/src/coremsg.c                          | 2 +-
> >  testsuites/validation/tc-message-construct-errors.c | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/cpukit/include/rtems/rtems/message.h
> b/cpukit/include/rtems/rtems/message.h
> > index 14083b8..7bb48ba 100644
> > --- a/cpukit/include/rtems/rtems/message.h
> > +++ b/cpukit/include/rtems/rtems/message.h
> > @@ -51,7 +51,7 @@ typedef struct {
> >     * @brief This member defines the maximum number of pending messages
> supported
> >     *   by the message queue.
> >     */
> > -  uint32_t maximum_pending_messages;
> > +  size_t maximum_pending_messages;
> >
> >    /**
> >     * @brief This member defines the maximum message size supported by
> the message
> > diff --git a/cpukit/include/rtems/score/coremsgimpl.h
> b/cpukit/include/rtems/score/coremsgimpl.h
> > index 6f6a01b..c7a424c 100644
> > --- a/cpukit/include/rtems/score/coremsgimpl.h
> > +++ b/cpukit/include/rtems/score/coremsgimpl.h
> > @@ -144,7 +144,7 @@ void *_CORE_message_queue_Workspace_allocate(
> >  Status_Control _CORE_message_queue_Initialize(
> >    CORE_message_queue_Control          *the_message_queue,
> >    CORE_message_queue_Disciplines       discipline,
> > -  uint32_t                             maximum_pending_messages,
> > +  size_t                               maximum_pending_messages,
> >    size_t                               maximum_message_size,
> >    CORE_message_queue_Allocate_buffers  allocate_buffers,
> >    const void                          *arg
> > diff --git a/cpukit/score/src/coremsg.c b/cpukit/score/src/coremsg.c
> > index cf7f44e..530f057 100644
> > --- a/cpukit/score/src/coremsg.c
> > +++ b/cpukit/score/src/coremsg.c
> > @@ -35,7 +35,7 @@ RTEMS_STATIC_ASSERT(
> >  Status_Control _CORE_message_queue_Initialize(
> >    CORE_message_queue_Control          *the_message_queue,
> >    CORE_message_queue_Disciplines       discipline,
> > -  uint32_t                             maximum_pending_messages,
> > +  size_t                               maximum_pending_messages,
> >    size_t                               maximum_message_size,
> >    CORE_message_queue_Allocate_buffers  allocate_buffers,
> >    const void                          *arg
> > diff --git a/testsuites/validation/tc-message-construct-errors.c
> b/testsuites/validation/tc-message-construct-errors.c
> > index 3512b45..170b687 100644
> > --- a/testsuites/validation/tc-message-construct-errors.c
> > +++ b/testsuites/validation/tc-message-construct-errors.c
> > @@ -338,7 +338,7 @@ static void
> RtemsMessageReqConstructErrors_Pre_MaxPending_Prepare(
> >         * configuration shall be big enough so that a calculation to get
> the
> >         * message buffer storage area size overflows.
> >         */
> > -      ctx->config.maximum_pending_messages = UINT32_MAX;
> > +      ctx->config.maximum_pending_messages = SIZE_MAX;
> >        break;
> >      }
> >
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210318/6ff1a115/attachment.html>