Fw: Re: ticket #3889

Sun Mar 28 00:47:57 UTC 2021

with the -rtems-test=Yes when you build the bsp?

Sent with [ProtonMail](https://protonmail.com) Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, March 28, 2021 12:37 AM, Joel Sherrill <joel at rtems.org> wrote:

> Did you enable all the tests and try to run it before you made modifications?
>
> On Sat, Mar 27, 2021, 7:35 PM zack_on_the_speed_chanel <zack_on_the_speed_chanel at protonmail.ch> wrote:
>
>> What file do i have to check in ? I thought posix was a standard so the code is platform agnostic? Is there code specific to the BSP? Also I tried to modify the psxtimer02 test file and change it the clock_monotonic to see what happens but when i run ./waf it does not reflect the changes I have made. I don't see a corresponding executable in /quick-start/src/rtems/build/sparc/erc32/testsuites/psxtests
>>
>> Thanks
>> Zack
>>
>> Sent with [ProtonMail](https://protonmail.com) Secure Email.
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On Saturday, March 27, 2021 9:22 PM, Joel Sherrill <joel at rtems.org> wrote:
>>
>>> On Sat, Mar 27, 2021, 3:52 PM zack_on_the_speed_chanel <zack_on_the_speed_chanel at protonmail.ch> wrote:
>>>
>>>> I found a part of the assembly that says that the path is not called.
>>>>
>>>> if ( ( flags & POSIX_CONDITION_VARIABLES_CLOCK_MONOTONIC ) != 0 ) {
>>>>
>>>> 40005594:   12 80 00 39     bne  40005678 <_POSIX_Condition_variables_Wait_support+0x118> <== NEVER TAKEN
>>>>
>>>> 40005598:   f4 27 bf e8     st  %i2, [ %fp + -24 ]
>>>>
>>>> So if i'm correct The BSP supports this fuction of CLOCK_Monotonic (because the assembly is archetcture specific)? Which means that there is a need for the test I assume?
>>>>
>>>> Also does leon= the same as  the bsp  erc32-sis (or the one in the tutorial)
>>>
>>> Please read the original source to confirm but I think you're right but it supports it but doesn't have a test.
>>>
>>> The ERC32 what's the first space hardened sparc processor. The leon3 is a later processor in the same family. Both use the same build of GCC and are just different bsps. In fact both run on the same sis simulator. It's just that a user starting today on a mission, is more likely to use the Leon3. The leon3 also can support SMP
>>>
>>>> Zack
>>>>
>>>> Sent with [ProtonMail](https://protonmail.com) Secure Email.
>>>>
>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>> On Saturday, March 27, 2021 7:50 PM, Joel Sherrill <joel at rtems.org> wrote:
>>>>
>>>>> On Sat, Mar 27, 2021 at 2:33 PM zack_on_the_speed_chanel <zack_on_the_speed_chanel at protonmail.ch> wrote:
>>>>>
>>>>>> Hello,
>>>>>> Last year I tried to do work and help to contribute to RTEMS. I didn't get too far but now I think I now I have a better shot at it! I was able to complete the BSP and tools build, and run the hello world examples. I want to work on small tickets first and work my way into the source code. The ticket is asking for a test clock_create with clock monotonic. here is the link for the ticket I'm referring to https://devel.rtems.org/ticket/3889 .My thinking is to look for code that does something similar. In the ticket it says that there is a test with clock_realtime. I was on the discord and someone suggested me to looking to the coverage tests. How come i don't see the function clock_create when looking at the annotated assembly code? Also I think the test should be based on this https://git.rtems.org/rtems/tree/testsuites/psxtests/psxtimer02/psxtimer.c
>>>>>
>>>>> That was me on Discord. :)
>>>>>
>>>>> Yep. psxtimer02 is a good test to start from since it is doing similar cases on a different clock.
>>>>>
>>>>> The coverage I was suggesting to look at is here:
>>>>>
>>>>> https://ftp.rtems.org/pub/rtems/people/joel/coverage/coverage-2021-02-28/
>>>>>
>>>>> Drill down to leon3 and posix and look at the timer methods (create, settime, gettime) for current coverage.
>>>>>
>>>>> But I warn you, it may or may not actually support the CLOCK_REALTIME and CLOCK_MONOTONIC as required here:
>>>>>
>>>>> https://pubs.opengroup.org/onlinepubs/9699919799/functions/timer_create.html
>>>>>
>>>>> So coverage may be high because the implementation of the posix methods themselves are missing something.
>>>>>
>>>>> Pull the thread a bit to see if the methods support the clock value in question. If so, we just need tests. If not, some code gets added to the timer manager and tests get added.
>>>>>
>>>>> --joel
>>>>>
>>>>>> Thanks
>>>>>> Zack
>>>>>>
>>>>>> _______________________________________________
>>>>>> devel mailing list
>>>>>> devel at rtems.org
>>>>>> http://lists.rtems.org/mailman/listinfo/devel
>>>>
>>>> _______________________________________________
>>>> devel mailing list
>>>> devel at rtems.org
>>>> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210328/9957a65e/attachment.html>