[PATCH v5] rtems-debugger: Fixed 32bit pointers

Chris Johns chrisj at rtems.org
Sun May 9 01:50:25 UTC 2021


On 8/5/21 6:13 am, Stephen Clark wrote:
> Using 32bit types like uint32_t for pointers creates issues on 64 bit
> architectures like AArch64. Replaced occurrences of these with uintptr_t,
> which will work for both 32 and 64 bit architectures. Added hex_decode_addr
> function to rtems-debugger. Changed rtems_debugger_target_swbreak_control()
> parameter to DB_ADDR.

The change seems to mix things. I originally added the DB_* defines in case
there needed to be a way to handle arch specifics and it looks like there does
not need to be.

If the interface to gdb can be handled by suitable types then I suggest the
macros be removed and only the types be used. I think mixing things like only
adds a layer of confusion.

Chris


More information about the devel mailing list