xz_crc64.c not compiled

Chris Johns chrisj at rtems.org
Tue Nov 8 00:52:48 UTC 2022


On 8/11/2022 3:23 am, Gedare Bloom wrote:
> On Fri, Nov 4, 2022 at 5:05 PM Chris Johns <chrisj at rtems.org> wrote:
>>
>> On 5/11/2022 6:46 am, Gedare Bloom wrote:
>>> On Fri, Nov 4, 2022 at 1:39 PM Joel Sherrill <joel at rtems.org> wrote:
>>>>
>>>>
>>>>
>>>> On Fri, Nov 4, 2022, 2:37 PM Gedare Bloom <gedare at rtems.org> wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> I don't see an entry in spec/build anywhere for xz_crc64.c
>>>>>
>>>>>  From what I can tell it is not compiled/tested. I guess the
>>>>> This leads me to believe it is not compiled. And therefore is not
>>>>> being called or tested anywhere.
>>>>>
>>>>> Should it be compiled, or should it be removed?
>>>>
>>>>
>>>> What about in 5 and the autotools build system?
>>>>
>>> It appears to be omitted from 5's cpukit/Makefile.am
>>>
>>> I don't see the code in 4.11. It was added by Chris to support untar
>>> of tgz files.
>>
>> Sorry I do not recall why it was not added into the build. There are no
>> calls in the code to it.
>>
> I guess the question then is whether to add it to the build and write
> a testsuite call to it, or to remove it from the tree.

Maybe add it? If you need to add a 64bit CRC the code is there?

Chris


More information about the devel mailing list