[PATCH 2/3] build: Replace variant patterns with a list

Chris Johns chrisj at rtems.org
Thu Jan 19 00:17:31 UTC 2023

On 18/1/2023 6:00 pm, Sebastian Huber wrote:
> On 18.01.23 04:59, Chris Johns wrote:
>> Hi Sebastian,
>> I had not got to this part of the patch set because the other was being
>> discussed. I thought a patch set was considerd as a whole rather than having to
>> deal with the extra complexity of possible splits and if they exist? If this was
>> pull request or merge request in a tool none of this patch set would have been
>> applied unless split into separate merge reguests. :)
> Sorry, I thought you were already finished with the patch set. Maybe we should
> move the patch review to pull requests.

I am still buried after being away and no I was not finsihed. I am sorry for the

>> Why has this been done?
> The enabled-by expressions used in patch 3 do not support regular expressions.

I did not pick that up. Why was that regx functionality removed? Is it related
to scripting and rtems-central?

>> Why the noise in the patch of only lines being moved? Where has this come from?
>> Is there a new requirement spec fields be in some osrt of order?
> I did the change with a script which sorted the lists. In general, the lists
> should be sorted.

This is a good example of problems a lack of scripting support along side the
build spec files creates. It makes manual changes difficult when rules get
layered like this plus it means you are the only one who can make generated
changes without there being a clash of scripting specifics, ie my script vs your
script or something like that.

And I have no intention in cloning rtems-central and learning how to use it.
There was a primary agreement for the separation of all qual work and the
ability for it to be removed from the project without any side effects.


More information about the devel mailing list